Bug 93763 - Reenable layer5-lock for de(neo), de(adnw) and de(koy)
Summary: Reenable layer5-lock for de(neo), de(adnw) and de(koy)
Status: RESOLVED FIXED
Alias: None
Product: xkeyboard-config
Classification: Unclassified
Component: General (show other bugs)
Version: unspecified
Hardware: All All
: medium enhancement
Assignee: xkb
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-01-18 19:17 UTC by n.reusse
Modified: 2016-01-26 21:04 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments
reenable the layer5-lock for neo, adnw and koy (19.46 KB, patch)
2016-01-18 19:17 UTC, n.reusse
Details | Splinter Review

Description n.reusse 2016-01-18 19:17:00 UTC
Created attachment 121118 [details] [review]
reenable the layer5-lock for neo, adnw and koy

This patch reenables the currently outcommented types that were introduced in 2010 and uses them in the de(neo)-layout (these types were introduced for neo) and in the two layouts that build upon neo, de(adnw) and de(koy).

It basically reverts commits [1] and [2] and enables the layer5-lock for these 3 layouts.

Both commits were disabled because there was an open bug on ubuntu 10.04 (powerpc) where gdm crashed when these two types were enabled [3].  X did not crash though.  Since it's been nearly 6 years, i had to give it another try.  The patch (and X) works without any problems on OpenBSD 5.9-current (amd64, dwm), OpenSuse Tumbleweed (amd64, gnome3) and Ubuntu 14.04 (amd64, xfce).  To really make a point, i also installed debian 9 (testing) for powerpc in a qemu-image with mate, the fork of gnome2 [4].  Thats as close as it gets for a gnome2-gdm on powerpc ;)  Whatever the problem might have been on the old ubuntu installation, it does not show on debian.  If necessary, i can provide the patched debian qemu-image.

Thanks!
Nils

[1] http://cgit.freedesktop.org/xkeyboard-config/commit/types/level5?id=798e048b1b8c8eda37bd04d2548597e6c05bb93c
[2] http://cgit.freedesktop.org/xkeyboard-config/commit/symbols/de?id=95d844882cefe4ab54bf27130ac0fdbb28cac311
[3] https://bugs.freedesktop.org/show_bug.cgi?id=27988
[4] http://mate-desktop.com
Comment 1 Sergey V. Udaltsov 2016-01-26 21:04:27 UTC
committed, thanks!


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.