Bug 97480 - [SKL/BDW/HSW Bisected] GpuTest 0.7.0 GiMark lighting is wrong
Summary: [SKL/BDW/HSW Bisected] GpuTest 0.7.0 GiMark lighting is wrong
Alias: None
Product: Mesa
Classification: Unclassified
Component: Drivers/DRI/i965 (show other bugs)
Version: git
Hardware: Other All
: medium normal
Assignee: Ian Romanick
QA Contact: Intel 3D Bugs Mailing List
Depends on:
Reported: 2016-08-25 08:49 UTC by Pekka Jylhä-Ollila
Modified: 2018-02-26 11:48 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Screenshot of GiMark (3.26 MB, image/png)
2016-08-25 08:49 UTC, Pekka Jylhä-Ollila

Description Pekka Jylhä-Ollila 2016-08-25 08:49:44 UTC
Created attachment 126030 [details]
Screenshot of GiMark

Lighting is broken in GiMark on SKL and BDW after the following commit:

commit ebdc82d06532f992aea592265c29a11330e698fa
Author: Kenneth Graunke <kenneth@whitecape.org>
Date:   Tue Jul 26 13:19:46 2016 -0700

    i965: Fix move_interpolation_to_top() pass.

The darker areas on the smaller rings are moving all over the surfaces. I attached a picture that shows the problem.

I saw this first on HSW but noticed it later on the two other platforms.
The commit above broke lighting on SKL and BDW, while it fixed lighting on HSW.

The commit where lighting got broken earlier on HSW is:

commit 8c7a42b3e880804e201ee9582a0a73763cdd2a01
Author: Matt Turner <mattst88@gmail.com>
Date:   Mon Feb 1 11:14:01 2016 -0800

    i965/fs: Allocate single register at a time for constants.
Comment 1 Andriy Khulap 2018-02-01 13:57:14 UTC
I can't run GpuTest properly:
GpuTest_Linux_x64_0.7.0 all tests with OpenGL version <= 3.0 (in test description) run well, all above (e.g. 3.5, 4.0 ... and the needed on GiMark OpenGL 3.3) exiting immediately without any error returned.

- Intel(R) Core(TM) i5-6440HQ CPU @ 2.60GHz
- Intel(R) HD Graphics 530 (Skylake GT2)  (0x191b)
- Ubuntu 16.04 LTS (lots of kernels and mesa version combinations).

Also tried on Haswell (don't remember the details) with the same result.

Pekka, could you please suggest if there any additional actions needed to run this test?
Comment 2 Tapani Pälli 2018-02-26 11:48:29 UTC
I was able to launch this using MESA_GL_VERSION_OVERRIDE=4.4, AFAICT lighting looks fine. I'm resolving this as WORKSFORME.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.