Bug 9767 - hald-addon-keyboard support for keyrepeat
Summary: hald-addon-keyboard support for keyrepeat
Status: RESOLVED FIXED
Alias: None
Product: hal
Classification: Unclassified
Component: hald (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: David Zeuthen (not reading bugmail)
QA Contact:
URL:
Whiteboard:
Keywords:
: 13873 (view as bug list)
Depends on:
Blocks:
 
Reported: 2007-01-26 01:10 UTC by Allison Lortie (desrt)
Modified: 2008-01-03 14:00 UTC (History)
2 users (show)

See Also:
i915 platform:
i915 features:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Allison Lortie (desrt) 2007-01-26 01:10:15 UTC
currently the keyboard addon ignores key repeat events (for example when holding the brightness key down).

this patch fixes that.
Comment 1 Allison Lortie (desrt) 2007-01-26 01:13:57 UTC
bugzilla is broken.  it keeps saying "the file you are trying to attach is empty"

here it is in all its glory:

diff --git a/hald/linux/addons/addon-keyboard.c b/hald/linux/addons/addon-keyboard.c
--- a/hald/linux/addons/addon-keyboard.c
+++ b/hald/linux/addons/addon-keyboard.c
@@ -166,7 +166,7 @@ main_loop (LibHalContext *ctx, FILE* eve
 
 	while (fread (&event, sizeof(event), 1, eventfp)) {
 		/* dbg ("event.code = %d (0x%02x)", event.code); */
-		if (key_name[event.code] && event.value == 1) {
+		if (key_name[event.code] && event.value) {
 			libhal_device_emit_condition (ctx, udi, 
 						      "ButtonPressed",
 						      key_name[event.code],


this makes it so you don't have to press press press press to change the brightness (but can just hold down).
Comment 2 Sjoerd Simons 2007-12-07 14:10:04 UTC
Committed the patch
Comment 3 Danny Kukawka 2008-01-03 14:00:40 UTC
*** Bug 13873 has been marked as a duplicate of this bug. ***


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct.