Bug 98143 - Handle missing client site name in NetLogon reply
Summary: Handle missing client site name in NetLogon reply
Status: RESOLVED FIXED
Alias: None
Product: realmd
Classification: Unclassified
Component: adcli (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Stef Walter
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-10-07 11:59 UTC by Sumit Bose
Modified: 2016-10-18 09:15 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments
Handle empty string in client site name (1.14 KB, patch)
2016-10-07 11:59 UTC, Sumit Bose
Details | Splinter Review

Description Sumit Bose 2016-10-07 11:59:42 UTC
Created attachment 127095 [details] [review]
Handle empty string in client site name

parse_disco_string() returns an empty string if there is no client site name in the NetLogon reply. Later in the code only a NULL check is used to check for a missing client site name. To make sure the empty string is not used as client site name it should be replaced with NULL.

Attached patch should fix this issue.
Comment 1 Stef Walter 2016-10-18 09:14:58 UTC
Attachment 127095 [details] pushed as 213116e - Handle empty string in client site name

Looks good. Merged into master.
Comment 2 Stef Walter 2016-10-18 09:15:14 UTC
Looks good. Merged into master.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.