Bug 98614 - Common up xdg-screensaver code that deals with Freedesktop desktop idleness inhibition API
Summary: Common up xdg-screensaver code that deals with Freedesktop desktop idleness i...
Status: NEW
Alias: None
Product: Portland
Classification: Unclassified
Component: xdg-utils (show other bugs)
Version: unspecified
Hardware: Other All
: medium enhancement
Assignee: Portland Bugs
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-11-06 17:30 UTC by Reuben Thomas
Modified: 2016-11-06 17:30 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Reuben Thomas 2016-11-06 17:30:25 UTC
At present xdg-screensaver contains several almost-identical functions to deal with the various desktops that implement the Freedesktop desktop idleness inhibition DBus API, or something like it.

One example is the code for MATE, which bears the following comment:

# DBUS interface for mate-screensaver
# This is same as gnome's for now but may change in the future as MATE
# does not follow gnome's developement necessarily.

I think this is an unfortunate attitude to take with respect to Freedesktop standards in Freedesktop project code. We should be optimistic about the adoption of standards, and encourage their use.

Hence, I suggest that the following functions have their common code factored out:

screensaver_freedesktop (ironically only used for KDE)
screensaver_mate_screensaver
screensaver_gnome_screensaver (also used for GNOME 3's gnome-shell)
screensaver_cinnamon_screensaver

Even some DBus end-points not covered by the Freedesktop spec, such as "SimulateUserActivity" are common between most or all of the above, with the exception of a different prefix.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.