Bug 98824 - Add flatpak support to xdg-open and xdg-email
Summary: Add flatpak support to xdg-open and xdg-email
Status: RESOLVED FIXED
Alias: None
Product: Portland
Classification: Unclassified
Component: xdg-utils (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Portland Bugs
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-11-22 22:44 UTC by Matt Watson
Modified: 2016-11-23 15:40 UTC (History)
2 users (show)

See Also:
i915 platform:
i915 features:


Attachments
xdg-open: add flatpak support (1.65 KB, patch)
2016-11-22 23:02 UTC, Matt Watson
Details | Splinter Review
xdg-email: add flatpak support (1.12 KB, patch)
2016-11-22 23:02 UTC, Matt Watson
Details | Splinter Review

Description Matt Watson 2016-11-22 22:44:17 UTC
With the addition of flatpak portals, flatpak apps can open up any uri in an appropriate external app. This means they could support xdg-open and xdg-email.

We detect the flatpak sandbox in xdg-open and xdg-email and call into the flatpak portal over dbus when appropriate. Then we can add xdg-utils to flatpak runtimes, and make life easier to apps relying on the tool.
Comment 1 Matt Watson 2016-11-22 23:02:16 UTC
Created attachment 128154 [details] [review]
xdg-open: add flatpak support
Comment 2 Matt Watson 2016-11-22 23:02:49 UTC
Created attachment 128155 [details] [review]
xdg-email: add flatpak support
Comment 3 Matt Watson 2016-11-23 08:38:01 UTC
Patches attached. Didn't bother adding a fallback if gdbus is not detected cause I think it should be fine to just error noisily in that case.

A commit showing how to build into a flatpak app is here, though hopefully this can go into the freedesktop runtime.

https://github.com/endlessm/electron-flatpak-base-app/commit/856e6847249948479ca62e4a4d579b13f083c589
Comment 4 Rex Dieter 2016-11-23 15:40:23 UTC
committed, thanks!


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.