Bug 98866 - do not overwrite environment variable DE if it is already set
Summary: do not overwrite environment variable DE if it is already set
Status: RESOLVED WONTFIX
Alias: None
Product: Portland
Classification: Unclassified
Component: xdg-utils (show other bugs)
Version: unspecified
Hardware: Other All
: medium enhancement
Assignee: Portland Bugs
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-11-26 23:52 UTC by Patrick Schleizer
Modified: 2016-11-28 14:53 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Schleizer 2016-11-26 23:52:08 UTC 
For /usr/bin/xdg-open please do not overwrite environment variable DE if it is already set.

(That would help us at Qubes OS with some issue. https://github.com/QubesOS/qubes-issues/issues/2065)

I am suggesting a trivial change.

Now:

```
detectDE

if [ x"$DE" = x"" ]; then
    DE=generic
fi
```

Suggested:

```
if [ x"$DE" = x"" ]; then
    detectDE
fi

if [ x"$DE" = x"" ]; then
    DE=generic
fi
```

What do you think?
Comment 1 Rex Dieter 2016-11-28 14:53:36 UTC 
DE is deprecated and an internal implementation detail.

If you insist, set/use the standardized XDG_CURRENT_DESKTOP variable instead.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.