The attached patch merges the almost identical code in the 16bpp and 32bpp paths in SAVAGEInitVisualConfigs.
I have tested the patch on a ProSavage device on FreeBSD with both 16 and 32 bpp.
Created attachment 8694 [details] [review]
Patch to merge the 16 and 32 bpp paths
Sorry about the phenomenal bug spam, guys. Adding xorg-team@ to the QA contact so bugs don't get lost in future.
Tormod, would you please review this patch, so we can close out this bug?
Created attachment 52234 [details] [review]
Updated patch for latest git
I think I'd like to rename the SAVAGEVisTable to for instance SavageVisuals since I find "Table" a bit redundant for naming a table. Otherwise looks good.
Andrew, can I use your bugzilla e-mail address for the author address?
Yes, you can use that address.