Bug 9961 - Merge almost identical code in SAVAGEInitVisualConfigs
Summary: Merge almost identical code in SAVAGEInitVisualConfigs
Status: RESOLVED FIXED
Alias: None
Product: xorg
Classification: Unclassified
Component: Driver/savage (show other bugs)
Version: unspecified
Hardware: All All
: low enhancement
Assignee: Tormod Volden
QA Contact: Xorg Project Team
URL:
Whiteboard: 2011BRB_Reviewed
Keywords:
Depends on:
Blocks:
 
Reported: 2007-02-12 20:55 UTC by Andrew Turner
Modified: 2012-01-03 14:07 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments
Patch to merge the 16 and 32 bpp paths (7.76 KB, patch)
2007-02-12 20:57 UTC, Andrew Turner
no flags Details | Splinter Review
Updated patch for latest git (7.75 KB, patch)
2011-10-11 12:22 UTC, Tormod Volden
no flags Details | Splinter Review

Description Andrew Turner 2007-02-12 20:55:50 UTC
The attached patch merges the almost identical code in the 16bpp and 32bpp paths in SAVAGEInitVisualConfigs.

I have tested the patch on a ProSavage device on FreeBSD with both 16 and 32 bpp.
Comment 1 Andrew Turner 2007-02-12 20:57:52 UTC
Created attachment 8694 [details] [review]
Patch to merge the 16 and 32 bpp paths
Comment 2 Daniel Stone 2007-02-27 01:36:23 UTC
Sorry about the phenomenal bug spam, guys.  Adding xorg-team@ to the QA contact so bugs don't get lost in future.
Comment 3 Jeremy Huddleston Sequoia 2011-10-09 17:56:42 UTC
Tormod, would you please review this patch, so we can close out this bug?
Comment 4 Tormod Volden 2011-10-11 12:22:02 UTC
Created attachment 52234 [details] [review]
Updated patch for latest git
Comment 5 Tormod Volden 2011-10-11 12:51:27 UTC
I think I'd like to rename the SAVAGEVisTable to for instance SavageVisuals since I find "Table" a bit redundant for naming a table. Otherwise looks good.

Andrew, can I use your bugzilla e-mail address for the author address?
Comment 6 Andrew Turner 2011-10-12 00:48:55 UTC
Yes, you can use that address.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.