Bug 99838 - device: Free errors after sending it to the bus
Summary: device: Free errors after sending it to the bus
Status: RESOLVED FIXED
Alias: None
Product: libfprint
Classification: Unclassified
Component: fprintd (show other bugs)
Version: unspecified
Hardware: All All
: medium normal
Assignee: libfprint-bugs
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-02-16 14:25 UTC by Christian Kellner
Modified: 2017-02-16 15:12 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments
device: Free errors after sending it to the bus (5.60 KB, patch)
2017-02-16 14:25 UTC, Christian Kellner
Details | Splinter Review
device: Properly initialize error variable (730 bytes, patch)
2017-02-16 15:03 UTC, Christian Kellner
Details | Splinter Review
device: Free errors after sending it to the bus (5.32 KB, patch)
2017-02-16 15:03 UTC, Christian Kellner
Details | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Christian Kellner 2017-02-16 14:25:13 UTC

    
Comment 1 Christian Kellner 2017-02-16 14:25:18 UTC
Created attachment 129671 [details] [review]
device: Free errors after sending it to the bus
Comment 2 Bastien Nocera 2017-02-16 14:51:52 UTC
Comment on attachment 129671 [details] [review]
device: Free errors after sending it to the bus

Review of attachment 129671 [details] [review]:
-----------------------------------------------------------------

::: src/device.c
@@ +604,4 @@
>  	g_message("device %d claim status %d", priv->id, status);
>  
>  	if (status != 0) {
> +		GError *error = NULL;

That should really have been split up.
Comment 3 Christian Kellner 2017-02-16 15:03:23 UTC
Created attachment 129673 [details] [review]
device: Properly initialize error variable
Comment 4 Christian Kellner 2017-02-16 15:03:29 UTC
Created attachment 129674 [details] [review]
device: Free errors after sending it to the bus
Comment 5 Bastien Nocera 2017-02-16 15:12:11 UTC
I already pushed the original patch split up, my git-bz got stuck :/


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.