Bug 18072

Summary:	[patch] remove unspecific OLE magic from application/x-msi
Product:	shared-mime-info	Reporter:	Stanislav Brabec <sbrabec>
Component:	freedesktop.org.xml	Assignee:	Bastien Nocera <bugzilla>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	medium	CC:	faure, felix
Version:	unspecified
Hardware:	Other
OS:	All
Whiteboard:
i915 platform:		i915 features:

Description Stanislav Brabec 2008-10-15 05:52:54 UTC

Bug 16495 introduced MIME type application/x-msi.

But in shared-mime-info-0.51, application/x-msi also includes generic OLE magic, which is even longer that generic OLE match included to application/x-ole-storage, but which is still not MSI specific and matches for many Microsoft Word documents.

That is why I propose to remove this magic. See bug 16495 comment 9 for patch.

Alternative solutions, which I cannot provide, because I have no specifications:

- Create a real MSI specific match.

- Move this magic (or its longer substring) to application/x-ole-storage.

Comment 1 David Faure 2008-10-17 07:33:34 UTC

Yes, this MSI magic is definitely wrong. I have a .dot file here (a msword template), which matches this magic. So obviously it is not specific to msi files.

Aren't msi files always called *.msi anyway? I don't think this magic is really necessary - especially if it matches non-msi files.

Comment 2 David Faure 2008-10-17 07:54:00 UTC

The test suite in fdo shows the issue, btw:
test-template.dot, 'data' test: expected application/msword-template, got application/x-msi (expected failure)                                                                               
test-template.dot, 'file' test: expected application/msword-template, got application/x-msi

Comment 3 David Faure 2009-01-05 10:02:32 UTC

Fixed today. Fix will be in the next release (current release is still 0.51).

/cvs/mime/shared-mime-info/ChangeLog,v  <--  ChangeLog
new revision: 1.512; previous revision: 1.511
/cvs/mime/shared-mime-info/freedesktop.org.xml.in,v  <--  freedesktop.org.xml.in
new revision: 1.390; previous revision: 1.389
/cvs/mime/shared-mime-info/tests/list,v  <--  tests/list
new revision: 1.63; previous revision: 1.62

This makes ole-storage magic work again, which triggers bug 18109 in the xdgmime code, but at least the spec is correct now for dot/doc/msi/ole-storage.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.