Originally found on launchpad: https://bugs.launchpad.net/ubuntu/+source/shared-mime-info/+bug/229062 There's a patch there as well, which looks correct. It would be very useful to have mime info for .msi files. Thank you.
Do you have a minimal test file available somewhere? Could you please also attach the patch here (minus the dup glob, they're case insensitive...)
Created attachment 17361 [details] [review] Adds application/x-msi as a sub-type of application/x-ole-storage Here is the patch, I hope it applies cleanly to the latest. Sorry I do not have a test case, I've never dealt with this source code before and don't really know how to make one.
(In reply to comment #2) > Sorry I do not have a test case, I've never dealt with this source code before > and don't really know how to make one. A small MSI file will do just fine. Apparently there is some magic available, and I'd like to be able to test it as well.
http://www.apache.org/dist/httpd/binaries/win32/apache_2.2.9-win32-x86-no_ssl-r2.msi Too big to attach to the bug (1000kb limit).
Any updates? I'm worried this will fall by the wayside due to me not finding a small test msi file.
2008-07-21 Bastien Nocera <hadess@hadess.net> * freedesktop.org.xml.in: Add MSI (Windows Installer) mime-type, including magic, based on work from Scott Ritchie <scott@open-vote.org> (Closes: #16495) * tests/list: * tests/test.msi: add test case for the above
This patch causes the detecten of ms-word documents to fail, see https://bugzilla.novell.com/show_bug.cgi?id=430389
This is a bug in kmimetypefinder, which only shows you the first matching mime-type, instead of the highest matching one (see the accuracy number). KDE doesn't use the xdgmime code, which works fine with this. Reopen a new bug if you have proof this is a shared-mime-info bug.
Created attachment 19663 [details] [review] shared-mime-info-msi-no-magic.patch The patch here is correct, but actual freedesktop.org.xml.in in 0.51 is incorrect, as it assigns generic OLE magic to both application/x-ole-storage and application/x-msi. It causes match for many Microsoft Word Document files. The magic attached to application/x-msi is a generic magic for application/x-ole-storage. Both matches have the same priority, but the match string for application/x-ole-storage is a substring of application/x-msi. This may cause prefix clash security warning, kmimetypefinder decides to prefer application/x-msi. This behavior is not in contradiction with spec as well. Proposed patch reverts version 0.51 back to the version proposed in previous patch. I am not a Microsoft OLE expert, I cannot provide a real application/x-msi specific magic.
As proposed in comment 8, I opened new bug 18072 for the new problem.
For the record (replying to comment 8) : kmimetypefinder does NOT show the first match, it does show the highest match. The bug is in the msi magic, see bug 18072.
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.