Bug 22970

Summary:	Non-portable Linux credentials passing not guarded by #ifdef
Product:	Telepathy	Reporter:	Simon McVittie <smcv>
Component:	salut	Assignee:	Simon McVittie <smcv>
Status:	RESOLVED FIXED	QA Contact:	Telepathy bugs list <telepathy-bugs>
Severity:	normal
Priority:	medium	CC:	sjoerd
Version:	git master	Keywords:	patch
Hardware:	All
OS:	BSD (Others)
URL:	http://git.collabora.co.uk/?p=user/smcv/salut-smcv.git;a=shortlog;h=refs/heads/gibbering-wreck
Whiteboard:
i915 platform:		i915 features:
Bug Depends on:	22968
Bug Blocks:

Description Simon McVittie 2009-07-27 14:17:23 UTC

Salut's copy of Gibber probably has the same problems as in Bug #22968. Hopefully the same patch will apply, but the tests will probably also have to be badgered so they don't expect credentials passing to work.

Comment 1 Simon McVittie 2009-08-25 12:09:04 UTC

Removing patch keyword, someone else will have to sort out the tests.

Comment 2 Simon McVittie 2010-05-07 08:10:25 UTC

I've mostly synched up libgibber with the version in Gabble. Any chance of a review? This should hopefully fix a release-critical Debian bug, <http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=565154>

This also includes some unrelated Windows and other-Unix portability changes, in the interests of reducing divergence.

Tested briefly by running `make check` with all __linux__ checks changed to look at an undefined macro.

I didn't incorporate the switch from GibberResolver to GResolver, since that would make Salut require a newer GLib, and it's nice to be able to ship Salut on Maemo 5 at least for the moment.

Comment 3 Simon McVittie 2010-05-20 03:16:14 UTC

Fixed in git for 0.3.12

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.