Bug 22970 - Non-portable Linux credentials passing not guarded by #ifdef
Summary: Non-portable Linux credentials passing not guarded by #ifdef
Status: RESOLVED FIXED
Alias: None
Product: Telepathy
Classification: Unclassified
Component: salut (show other bugs)
Version: git master
Hardware: All BSD (Others)
: medium normal
Assignee: Simon McVittie
QA Contact: Telepathy bugs list
URL: http://git.collabora.co.uk/?p=user/sm...
Whiteboard:
Keywords: patch
Depends on: 22968
Blocks:
  Show dependency treegraph
 
Reported: 2009-07-27 14:17 UTC by Simon McVittie
Modified: 2010-05-20 03:16 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments

Description Simon McVittie 2009-07-27 14:17:23 UTC
Salut's copy of Gibber probably has the same problems as in Bug #22968. Hopefully the same patch will apply, but the tests will probably also have to be badgered so they don't expect credentials passing to work.
Comment 1 Simon McVittie 2009-08-25 12:09:04 UTC
Removing patch keyword, someone else will have to sort out the tests.
Comment 2 Simon McVittie 2010-05-07 08:10:25 UTC
I've mostly synched up libgibber with the version in Gabble. Any chance of a review? This should hopefully fix a release-critical Debian bug, <http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=565154>

This also includes some unrelated Windows and other-Unix portability changes, in the interests of reducing divergence.

Tested briefly by running `make check` with all __linux__ checks changed to look at an undefined macro.

I didn't incorporate the switch from GibberResolver to GResolver, since that would make Salut require a newer GLib, and it's nice to be able to ship Salut on Maemo 5 at least for the moment.
Comment 3 Simon McVittie 2010-05-20 03:16:14 UTC
Fixed in git for 0.3.12


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.