| Summary: | Should stop adding #1 to ID | ||
|---|---|---|---|
| Product: | Telepathy | Reporter: | Guillaume Desmottes <guillaume.desmottes> |
| Component: | butterfly | Assignee: | Louis-Francis Ratté-Boulianne <lfrb> |
| Status: | RESOLVED FIXED | QA Contact: | Telepathy bugs list <telepathy-bugs> |
| Severity: | normal | ||
| Priority: | medium | CC: | mardy |
| Version: | unspecified | ||
| Hardware: | Other | ||
| OS: | All | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
|
Description
Guillaume Desmottes
2009-12-14 05:03:43 UTC
For reference, here is a patch which remove the #1 and only add #yahoo if it's an external yahoo contact. We still need agreement if this is the right choice and how to provide a migration path in Empathy. http://git.collabora.co.uk/?p=user/olethanh/telepathy-butterfly.git;a=shortlog;h=refs/heads/networkid I thought we already merged that patch. Was there any reason for not accepting the patch ? Backward compatibility maybe ? Nope I've updated it in my repo but it's not merged yet. I'm still waiting for the ok from Empath/MC people. (In reply to comment #2) > I thought we already merged that patch. Was there any reason for not accepting > the patch ? Backward compatibility maybe ? The only problem is Empathy. If we merge this patch, then users will have confusing logs. I just had a look at the code and it looks like the only way forward is to do a one-time move of all logs from "foo@msn.com#1" to "foo@msn.com". Although there are some "#1"s in the actual logs, I don't think that will matter. This patch is already in the maemo version of butterfly. *** Bug 23497 has been marked as a duplicate of this bug. *** I've done the work to get log migration working in Empathy. See:
https://bugzilla.gnome.org/show_bug.cgi?id=612519
When this Empathy branch is merged and released, we can merge this branch.
I've brought the two patches up to current git master:
http://git.collabora.co.uk/?p=user/jonny/telepathy-butterfly.git;a=shortlog;h=refs/heads/networkid
I'll write the NEWS entry when it's merged.
The empathy patch has been merged and released so we can probably merge this one now |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.