Bug 25635 - Should stop adding #1 to ID
Summary: Should stop adding #1 to ID
Status: RESOLVED FIXED
Alias: None
Product: Telepathy
Classification: Unclassified
Component: butterfly (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Louis-Francis Ratté-Boulianne
QA Contact: Telepathy bugs list
URL:
Whiteboard:
Keywords:
: 23497 (view as bug list)
Depends on:
Blocks:
 
Reported: 2009-12-14 05:03 UTC by Guillaume Desmottes
Modified: 2010-03-19 17:26 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments

Description Guillaume Desmottes 2009-12-14 05:03:43 UTC
Post fixing all contact ID with #1 is really annoying; Butterfly should stop doing that.

Note that we should have a smooth migration path to not break logs in Empathy.
Comment 1 Olivier Le Thanh Duong 2009-12-27 17:50:15 UTC
For reference, here is a patch which remove the #1 and only add #yahoo if it's an external yahoo contact. We still need agreement if this is the right choice and how to provide a migration path in Empathy.

http://git.collabora.co.uk/?p=user/olethanh/telepathy-butterfly.git;a=shortlog;h=refs/heads/networkid
Comment 2 Louis-Francis Ratté-Boulianne 2010-01-18 18:46:19 UTC
I thought we already merged that patch. Was there any reason for not accepting the patch ? Backward compatibility maybe ?
Comment 3 Olivier Le Thanh Duong 2010-01-18 23:26:06 UTC
Nope I've updated it in my repo but it's not merged yet. I'm still waiting for the ok from Empath/MC people.
Comment 4 Jonny Lamb 2010-01-19 03:01:02 UTC
(In reply to comment #2)
> I thought we already merged that patch. Was there any reason for not accepting
> the patch ? Backward compatibility maybe ?

The only problem is Empathy. If we merge this patch, then users will have confusing logs. I just had a look at the code and it looks like the only way forward is to do a one-time move of all logs from "foo@msn.com#1" to "foo@msn.com". Although there are some "#1"s in the actual logs, I don't think that will matter.

This patch is already in the maemo version of butterfly.
Comment 5 Olivier Le Thanh Duong 2010-02-01 05:52:04 UTC
*** Bug 23497 has been marked as a duplicate of this bug. ***
Comment 6 Jonny Lamb 2010-03-12 10:07:17 UTC
I've done the work to get log migration working in Empathy. See:

    https://bugzilla.gnome.org/show_bug.cgi?id=612519

When this Empathy branch is merged and released, we can merge this branch.

I've brought the two patches up to current git master:

    http://git.collabora.co.uk/?p=user/jonny/telepathy-butterfly.git;a=shortlog;h=refs/heads/networkid

I'll write the NEWS entry when it's merged.
Comment 7 Olivier Le Thanh Duong 2010-03-19 17:26:25 UTC
The empathy patch has been merged and released so we can probably merge this one now


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.