Bug 10226 - "find -not" not portable
Summary: "find -not" not portable
Status: RESOLVED FIXED
Alias: None
Product: cairo
Classification: Unclassified
Component: general (show other bugs)
Version: 1.4.0
Hardware: x86-64 (AMD64) NetBSD
: medium normal
Assignee: Carl Worth
QA Contact: cairo-bugs mailing list
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-03-08 13:32 UTC by Thomas Klausner
Modified: 2007-03-16 09:24 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments
Patch for RELEASING (545 bytes, patch)
2007-03-08 13:33 UTC, Thomas Klausner 		Details | Splinter Review
Patch for src/check-headers.sh (474 bytes, patch)
2007-03-08 13:34 UTC, Thomas Klausner 		Details | Splinter Review
View All

Description Thomas Klausner 2007-03-08 13:32:49 UTC 
cairo-1.4.0 uses "find -not".
The man page for GNU find says:
       -not expr
              Same as ! expr, but not POSIX compliant.

And actually, on e.g. NetBSD, "-not" is not supported.
Please use "!" instead.
I'll attach patches.
Comment 1 Thomas Klausner 2007-03-08 13:33:42 UTC 
Created attachment 9045 [details] [review]
Patch for RELEASING
Comment 2 Thomas Klausner 2007-03-08 13:34:17 UTC 
Created attachment 9046 [details] [review]
Patch for src/check-headers.sh
Comment 3 Carl Worth 2007-03-16 09:24:27 UTC 
Thanks for the report, and the fix. This is pushed now into cairo 1.4.1, (and soon to appear in the 1.4.2 release). See here:

http://gitweb.freedesktop.org/?p=cairo;a=commit;h=8236282c5d58320173b17659e488384e710d0ea7

-Carl

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.