Bug 10876 - mklib script doesn't accept the -pthread flag
Summary: mklib script doesn't accept the -pthread flag
Status: RESOLVED FIXED
Alias: None
Product: Mesa
Classification: Unclassified
Component: Other (show other bugs)
Version: 6.5
Hardware: Other FreeBSD
: medium normal
Assignee: mesa-dev
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-05-06 11:01 UTC by Diego Elio Pettenò
Modified: 2007-05-08 13:03 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments
mesa-6.5.3-pthread.patch (298 bytes, patch)
2007-05-06 11:01 UTC, Diego Elio Pettenò 		Details | Splinter Review
View All

Description Diego Elio Pettenò 2007-05-06 11:01:20 UTC 
As per summary, the mklib script in Mesa 6.5.3 does not accept the parameter -pthread for the linking parameters; such a parameter is used on some platforms to enable the default implementation of Posix threads, and as such is present as if it were a library.

The attached patch adds -pthread to DEPS verbatim.

Thanks,
Diego
Comment 1 Diego Elio Pettenò 2007-05-06 11:01:33 UTC 
Created attachment 9889 [details] [review]
mesa-6.5.3-pthread.patch
Comment 2 Brian Paul 2007-05-07 07:37:12 UTC 
Are you using mklib for a projects outside of Mesa?  I don't see any Mesa configs that use -pthread (they're all -lpthread as far as I can see).
Comment 3 Diego Elio Pettenò 2007-05-07 16:49:26 UTC 
Nope, it's just that Gentoo's ebuild for Mesa passes the output of pkg-config --libs x11-xcb to the Mesa build system, which in turns get it into mklib, and in this case it uses -pthread (coming from libX11's pkg-config data, with pkg-config configured, for Gentoo/FreeBSD, to get also the .private mappings).
It's a domino effect.
Comment 4 Brian Paul 2007-05-08 13:03:14 UTC 
OK, fixed in git.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.