Bug 10895 - The buggy_repeat path should be removed for Xsun now
Summary: The buggy_repeat path should be removed for Xsun now
Status: RESOLVED FIXED
Alias: None
Product: cairo
Classification: Unclassified
Component: xlib backend (show other bugs)
Version: 1.4.6
Hardware: SPARC Solaris
: medium normal
Assignee: Carl Worth
QA Contact: cairo-bugs mailing list
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-05-09 00:10 UTC by elaine
Modified: 2007-05-10 11:37 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:

Attachments
to remove the buggy_repeat path (520 bytes, patch)
2007-05-09 00:21 UTC, elaine 		Details | Splinter Review
View All

Description elaine 2007-05-09 00:10:59 UTC 
The setting of buggy_repeat is based on ServerVendor and VendorRelease. But now the buggy_repeat path is obsolete for Xsun, especially when xrender is enabled
Comment 1 elaine 2007-05-09 00:21:00 UTC 
Created attachment 9904 [details] [review]
to remove the buggy_repeat path
Comment 2 Behdad Esfahbod 2007-05-09 11:27:12 UTC 
What do you mean?  You mean that no version of Sun's X server has the bug?
Comment 3 Brian Cameron 2007-05-10 06:28:48 UTC 
Yes, actually I submitted the original patch for this.  Sun never released a version of Solaris with Xorg with the buggy repeat problem.  This patch was only needed for development versions of Solaris Nevada (roughly builds 25-30).  The latest S10U release and Nevada releases have a fixed Xorg.  So no users should ever encounter this bug.

We need to remove this test because Xsun has the same VendorString and a lower VendorRelease number so it falsely triggers buggy_repeat to be turned on.  They just added Xrender support recently to Xsun, so this wasn't an issue before recently.
Comment 4 Behdad Esfahbod 2007-05-10 10:58:41 UTC 
Committed: 195112697fac77e70ef36e00a2d557eda1e0e145
Comment 5 Carl Worth 2007-05-10 11:37:41 UTC 
By the way, thank you very much for providing the detailed explanation.

It's extremely useful for us to have details like that in our code's history.

So, thanks!

-Carl

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.