Bug 11136 - bus name and object path not correctly set
Summary: bus name and object path not correctly set
Status: RESOLVED FIXED
Alias: None
Product: Telepathy
Classification: Unclassified
Component: tp-python (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Telepathy bugs list
QA Contact: Telepathy bugs list
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-06-04 07:41 UTC by Ali Sabil
Modified: 2007-07-02 11:50 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments
Proposed patch (2.09 KB, patch)
2007-06-04 07:42 UTC, Ali Sabil 		Details | Splinter Review
Proposed fixed patch (2.12 KB, patch)
2007-06-04 07:45 UTC, Ali Sabil 		Details | Splinter Review
Show Obsolete (1) View All

Description Ali Sabil 2007-06-04 07:41:19 UTC 
The current tp-python sets the bus name using :
clean_account = re.sub('[^a-zA-Z0-9_]', '_', account)
bus_name = dbus.service.BusName('org.freedesktop.Telepathy.Connection.' + clean_account)

Which is incorrect according to the spec
Comment 1 Ali Sabil 2007-06-04 07:42:24 UTC 
Created attachment 10175 [details] [review]
Proposed patch

The attached patch fixes the busname and object path, and uses the same name mangling as the one used in tp-glib
Comment 2 Ali Sabil 2007-06-04 07:45:54 UTC 
Created attachment 10176 [details] [review]
Proposed fixed patch

The loop forgets to set is_first to False
Comment 3 Simon McVittie 2007-07-02 11:50:58 UTC 
Fixed in 0.13.13. Thanks for the patch.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.