Bug 11187 - build fixes for ABWOutputDev
Summary: build fixes for ABWOutputDev
Status: RESOLVED FIXED
Alias: None
Product: poppler
Classification: Unclassified
Component: general (show other bugs)
Version: unspecified
Hardware: Other Linux (All)
: medium normal
Assignee: poppler-bugs
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-06-07 03:49 UTC by Jens Granseuer
Modified: 2007-06-13 13:39 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments
change "and", "or", "not" to "&&", "||", "!" (14.73 KB, patch)
2007-06-07 03:50 UTC, Jens Granseuer 		Details | Splinter Review
removes dependency on debugxml (1.78 KB, patch)
2007-06-13 01:04 UTC, Jauco Noordzij 		Details | Splinter Review
View All

Description Jens Granseuer 2007-06-07 03:49:21 UTC 
Do more recent compilers actually support "and", "or", and "not" operators?

Patch attached.

There's one other problem I'm not sure how to fix best:
xmlLsCountNode which is used in ABWOutputDev is only available in libxml if it has been compiled with LIBXML_DEBUG_ENABLED, so it's probably a bad idea to rely on it being present. FWIW, it's not on my installation...
Comment 1 Jens Granseuer 2007-06-07 03:50:15 UTC 
Created attachment 10221 [details] [review]
change "and", "or", "not" to "&&", "||", "!"
Comment 2 Jeff Muizelaar 2007-06-07 14:27:04 UTC 
Patch applied. Not sure what to do about xmlLsCountNode, but it does indeed look like using it is not a good idea.
Comment 3 Jauco Noordzij 2007-06-13 01:04:26 UTC 
Created attachment 10293 [details] [review]
removes dependency on debugxml
Comment 4 Albert Astals Cid 2007-06-13 13:39:37 UTC 
Patch commited

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.