Bug 11331 - Inconsistent behaviour with Initiate Scale keybindings
Summary: Inconsistent behaviour with Initiate Scale keybindings
Status: RESOLVED FIXED
Alias: None
Product: xorg
Classification: Unclassified
Component: App/compiz (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: David Reveman
QA Contact: Xorg Project Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-06-21 21:23 UTC by Alyssa Hung
Modified: 2008-11-24 00:50 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments
Changed behavior of button presses for scale (3.36 KB, patch)
2007-09-29 17:50 UTC, Benson Tsai
no flags Details | Splinter Review
Additional changes to scale behavior (4.40 KB, patch)
2007-10-06 22:32 UTC, Benson Tsai
no flags Details | Splinter Review

Description Alyssa Hung 2007-06-21 21:23:58 UTC
When I initiate Scale mode with either a key binding, a mouse binding, or a corner trigger, I expect Scale mode to remain active until I select a window or untrigger it by invoking a binding again.

Presently, that is the behaviour I see when Scale is triggered using a corner trigger or using a key binding that doesn't involve any modifiers (Ctrl, Super, Shift, or Alt).

However, when Scale is triggered using a key binding involving modifiers, Scale mode exits as soon as I release at least one of the modifier keys. When triggered using a mouse binding, Scale mode exits as soon as I release the mouse button that triggered it. This creates an odd situation where I must continue holding onto the mouse button that triggered Scale in order to select a window and exit Scale mode normally.

Would it make more sense for Scale mode to remain active until a window is selected or the trigger is re-invoked in all cases?
Comment 1 Benson Tsai 2007-09-29 17:50:16 UTC
Created attachment 11823 [details] [review]
Changed behavior of button presses for scale

This patch changes the behavior of button presses to scale from press to initiate and release to quit, to press to initiate and press again to quit.

I just removed ScaleTerminate from button events and made InitiateScale* call terminate if scale is already in effect.
Comment 2 Benson Tsai 2007-10-06 22:32:44 UTC
Created attachment 11924 [details] [review]
Additional changes to scale behavior

With this patch, triggering any event a second time will cause scale to exit (which includes pressing the same button twice). The edge case is still handled the same way though...
Comment 3 Robert Lange 2007-11-13 22:02:40 UTC
I fixed the summary title, which erroneously stated "Scape keybindings" instead of "Scale keybindings". This may have made the bug harder to search for.

I hope the fix gets included soon. The current behavior is really annoying.
Comment 4 Alyssa Hung 2007-11-18 18:20:45 UTC
I apologise for not responding earlier. The patch posted by Benson Tsai is working perfectly now that I have my Compiz configuration sorted. Triggering the mouse action once to enter, then again to exit Scale mode is exactly the behaviour I was hoping to see. ^_^

If only something could be done about making the keyboard action not require modifiers to remain held down to stay in Scale mode, then this bug would be resolved.
Comment 5 Danny Baumann 2008-11-24 00:50:33 UTC
Commit d2bd7d5f1adb93481fcb8917b5e480e45bce4d48 made this behaviour optional, which should fix this bug.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.