Bug 11461 - UIM causes file descriptor leaks on error
Summary: UIM causes file descriptor leaks on error
Status: RESOLVED FIXED
Alias: None
Product: UIM
Classification: Unclassified
Component: helper: others (show other bugs)
Version: unspecified
Hardware: All All
: medium normal
Assignee: uim-bugs
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-07-03 12:10 UTC by Christian Biere
Modified: 2007-07-03 18:55 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
This patch should fix the leaks. (1.74 KB, patch)
2007-07-03 12:12 UTC, Christian Biere
Details | Splinter Review

Description Christian Biere 2007-07-03 12:10:28 UTC
In uim/uim-helper-client.c there are several places in which the created file descriptors and handles are not closed if an error occurs. A simple way to reproduce this is removing the x-bit from uim-helper-server or this file altogether. These functions are called quite frequently so an application can run quickly out of file descriptors.
Comment 1 Christian Biere 2007-07-03 12:12:09 UTC
Created attachment 10572 [details] [review]
This patch should fix the leaks.
Comment 2 Etsushi Kato 2007-07-03 18:55:59 UTC
Good catch!  I haven't notice the problem as uim-helper-server is assumed to work without problem.

Now your patch is applied to the svn trunk.  Thanks.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.