Bug 11588 - glGetShaderiv returns lenghts without null
Summary: glGetShaderiv returns lenghts without null
Status: RESOLVED FIXED
Alias: None
Product: Mesa
Classification: Unclassified
Component: Mesa core (show other bugs)
Version: git
Hardware: Other All
: low trivial
Assignee: mesa-dev
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-07-13 12:11 UTC by Jan Dvorak
Modified: 2009-08-24 12:27 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
glgetshader/glgetprogram patch (1.11 KB, patch)
2007-07-13 13:24 UTC, Jan Dvorak
Details | Splinter Review

Description Jan Dvorak 2007-07-13 12:11:53 UTC
The glGetShaderiv function returns lengths (GL_INFO_LOG_LENGTH and GL_SHADER_SOURCE_LENGTH) without including the null terminating character (the spec says it should include it)
Comment 1 Brian Paul 2007-07-13 12:55:12 UTC
The functions that implement those queries are in src/mesa/shader/shader_api.c.  Maybe you could try fixing things and submitting a patch?
Comment 2 Jan Dvorak 2007-07-13 13:24:57 UTC
Created attachment 10714 [details] [review]
glgetshader/glgetprogram patch

I wasn't sure if it isn't deliberate :) Anyway, here's patch
Comment 3 Brian Paul 2007-07-13 13:38:03 UTC
Thanks.  That looks good, but there's also a length returned by the glGetInfoLogARB() function.  So you might check/test the _mesa_get_shader/program_info_log() functions to see if they're correct or off by one.
Comment 4 Jan Dvorak 2007-07-13 14:42:46 UTC
(In reply to comment #3)
> Thanks.  That looks good, but there's also a length returned by the
> glGetInfoLogARB() function.  So you might check/test the
> _mesa_get_shader/program_info_log() functions to see if they're correct or off
> by one.
> 
They're returning number of characters written into buffer, excluding the terminator, so yes, they are correct.
Comment 5 Brian Paul 2007-07-13 15:37:29 UTC
Fixed in git.  Thanks!
Comment 6 Adam Jackson 2009-08-24 12:27:19 UTC
Mass version move, cvs -> git


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.