Bug 12768 - Height metrics not correct
Summary: Height metrics not correct
Status: RESOLVED FIXED
Alias: None
Product: cairo
Classification: Unclassified
Component: quartz font backend (show other bugs)
Version: 1.5.1
Hardware: Other All
: medium normal
Assignee: Carl Worth
QA Contact: cairo-bugs mailing list
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-10-10 03:01 UTC by Richard Hult
Modified: 2007-11-05 02:22 UTC (History)
2 users (show)

See Also:
i915 platform:
i915 features:

Attachments
Uses ascent+descent+leading to get the distance between baselines (617 bytes, patch)
2007-10-10 03:03 UTC, Richard Hult 		Details | Splinter Review
View All

Description Richard Hult 2007-10-10 03:01:37 UTC 
The height is currently mapped to the atsui metrics property capHeight, which is documented as "The height of a capital letter in the font from the baseline to the top of the letter".

That doesn't match what height is in cairo, it should be the disctance between baselines. Will attach a patch that fixes this (and makes webkit on GTK+ OS X layout nicely).
Comment 1 Richard Hult 2007-10-10 03:03:04 UTC 
Created attachment 11965 [details] [review]
Uses ascent+descent+leading to get the distance between baselines
Comment 2 Richard Hult 2007-11-02 14:32:02 UTC 
Adding Brian for feedback, hope that's OK.
Comment 3 Brian Ewins 2007-11-04 10:15:24 UTC 
This looks obviously correct, thanks Richard. I've got this in my tree, I'll push it out as soon as Chris has the main branch building again (later today I expect)
Comment 4 Brian Ewins 2007-11-05 02:22:49 UTC 
pushed as 4270cd3358fabf0d3e6ac4e866099b172082b592

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.