Bug 12953 - [patch] add OOM check to main.c
Summary: [patch] add OOM check to main.c
Status: RESOLVED FIXED
Alias: None
Product: dbus
Classification: Unclassified
Component: core (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Havoc Pennington
QA Contact: John (J5) Palmieri
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-10-26 02:31 UTC by Kimmo Hämäläinen
Modified: 2010-03-16 10:12 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments
proposed patch (561 bytes, patch)
2007-10-26 02:32 UTC, Kimmo Hämäläinen
Details | Splinter Review

Description Kimmo Hämäläinen 2007-10-26 02:31:56 UTC
attaching a patch.
Comment 1 Kimmo Hämäläinen 2007-10-26 02:32:17 UTC
Created attachment 12210 [details] [review]
proposed patch
Comment 2 Havoc Pennington 2007-10-26 09:29:10 UTC
Rather than exit(1), should probably either just warn and return (like the other failure below it) or do a bus_wait_for_memory thing
Comment 3 Kimmo Hämäläinen 2007-10-28 23:46:23 UTC
(In reply to comment #2)
> Rather than exit(1), should probably either just warn and return (like the
> other failure below it) or do a bus_wait_for_memory thing

All the failure code in the function do exit(1) -- should I change those to "return FALSE" as well?
Comment 4 Colin Walters 2010-03-16 10:12:17 UTC
I've pushed a version of this patch which uses _dbus_wait_for_memory().


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.