Bug 13435 - xdg-email - Thunderbird does not support email attachments
Summary: xdg-email - Thunderbird does not support email attachments
Status: RESOLVED FIXED
Alias: None
Product: Portland
Classification: Unclassified
Component: xdg-utils (show other bugs)
Version: 1.0
Hardware: x86 (IA32) Linux (All)
: medium normal
Assignee: Fathi Boudra
QA Contact:
URL:
Whiteboard:
Keywords: patch
Depends on:
Blocks: 23105
  Show dependency treegraph
 
Reported: 2007-11-28 14:47 UTC by Lei Zhang
Modified: 2010-11-27 15:36 UTC (History)
3 users (show)

See Also:
i915 platform:
i915 features:


Attachments
proposed fix (3.27 KB, patch)
2007-11-28 14:47 UTC, Lei Zhang
Details | Splinter Review
to_thunderbird.diff (824 bytes, patch)
2010-02-28 05:50 UTC, Pablo Castellano (pablog)
Details | Splinter Review
thunderbird_trailing_comma.diff (804 bytes, patch)
2010-04-30 04:38 UTC, Pablo Castellano (pablog)
Details | Splinter Review

Description Lei Zhang 2007-11-28 14:47:00 UTC
On http://portland.freedesktop.org/wiki/EmailConfig, it says Moziila Thunderbird does not support email attachments from xdg-email.

It turns out Thunderbird disabled attachments via a mailto: URL on purpose, because they believe it is not secure. [1]

I'm proposing the following workaround: (see attachment)

In open_kde() / open_gnome(), look up the email client kde/gnome is trying to run. If the client contains Thunderbird in its name, then call run_thunderbird(), which parses the mailto url, reformats it in a way that Thunderbird accepts, and then run Thunderbird.

open_xfce() does not need to do this because exo-open already does this. [2]

[1] https://bugzilla.mozilla.org/show_bug.cgi?id=99055#c6
[2] http://svn.xfce.org/svn/xfce/libexo/trunk/exo-helper/helpers/exo-compose-mail-0.3
Comment 1 Lei Zhang 2007-11-28 14:47:34 UTC
Created attachment 12807 [details] [review]
proposed fix
Comment 2 Noèl Köthe 2009-07-13 01:37:44 UTC
will the proposed fix from Comment #1 be integrated?
Comment 3 Nicolas Lécureuil 2009-08-03 14:17:48 UTC
fabo, can you review this patch please ?
Comment 4 Chris 2009-10-03 16:10:53 UTC
Can confirm bug, and also that the patch works.
Comment 6 Pablo Castellano (pablog) 2010-02-28 05:50:47 UTC
Created attachment 33640 [details] [review]
to_thunderbird.diff

Hi Fathi.
It looks like you committed the patch with an error and the "TO:" field isn't working.

Here's a patch to fix it.
Comment 7 Pablo Castellano (pablog) 2010-02-28 05:51:23 UTC
"TO:" field is not working.
Patch attached
Comment 8 Fathi Boudra 2010-02-28 06:02:06 UTC
oups, sorry. fixed.
Comment 9 Oxmosys 2010-02-28 09:40:32 UTC
Unfortunately, this fix does not work anymore with thunderbird 3, because of two regressions in the way thunderbird 3 handle -compose. I've reported the issue in thunderbird bugzilla and all details about this problem can be found here :

https://bugzilla.mozilla.org/show_bug.cgi?id=549058

I guess that this has to be fixed in thunderbird and not xdg-utils, but I might be wrong.
Comment 10 Robert Ancell 2010-03-11 21:28:03 UTC
Strips the trailing comma as required by Thunderbird 3:
ATTACH=$(echo "$MAILTO" | sed 's/^attach=/\n\nfile:\/\//g' | awk '/^file:/ { printf "%s,",$0 }')
ATTACH=$(echo "$ATTACH" | sed 's/,$//')
Comment 11 Pablo Castellano (pablog) 2010-04-30 04:38:33 UTC
Created attachment 35340 [details] [review]
thunderbird_trailing_comma.diff

Patch tested and working following Robert's last comment.
Comment 12 Pablo Castellano (pablog) 2010-07-18 14:10:46 UTC
a friendly ping, can we finally patch&close this bug?
Comment 13 Fathi Boudra 2010-09-24 10:48:30 UTC
fixed in CVS
Comment 14 Rich Wales 2010-11-27 15:36:31 UTC
I added the above patch to the /usr/bin/xdg-email on my Ubuntu Maverick system, but it doesn't seem to help.  I still get an error when I try to e-mail photos from Picasa 2.7 to Thunderbird 3.1.6.  Any suggestions are welcome regarding things I can do to help track down the problem.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.