Bug 13701 - grandr crashes when clicking on icon in left bar
Summary: grandr crashes when clicking on icon in left bar
Status: RESOLVED MOVED
Alias: None
Product: xorg
Classification: Unclassified
Component: App/xrandr (show other bugs)
Version: 7.2 (2007.02)
Hardware: x86 (IA32) Linux (All)
: medium normal
Assignee: Keith Packard
QA Contact: Xorg Project Team
URL:
Whiteboard: 2011BRB_Reviewed
Keywords:
Depends on:
Blocks:
 
Reported: 2007-12-17 06:19 UTC by Alexander Prinsier
Modified: 2018-08-10 20:33 UTC (History)
3 users (show)

See Also:
i915 platform:
i915 features:


Attachments
grandr-fix-crash-on-inactive-display.patch (474 bytes, patch)
2008-01-09 01:43 UTC, Priit Laes (irc: plaes)
no flags Details | Splinter Review

Description Alexander Prinsier 2007-12-17 06:19:22 UTC
(Bug about grandr, not xrandr, but grandr was not in the list... I hope this is the right place?:))

When clicking on the screen icon in the left of grandr, it crashes, and I see this as output on my terminal:

(grandr:13206): Gtk-CRITICAL **: gtk_list_store_get_value: assertion `VALID_ITER (iter, list_store)' failed

(grandr:13206): GLib-GObject-WARNING **: gtype.c:3339: type id `0' is invalid

(grandr:13206): GLib-GObject-WARNING **: can't peek value table for type `<invalid>' which is not currently referenced
Segmentation fault (core dumped)

Running gdb /usr/bin/grandr core gives this:
[...]
Core was generated by `grandr'.
Program terminated with signal 11, Segmentation fault.
#0  0x4c91ad05 in gtk_tree_model_get_valist () from /usr/lib/libgtk-x11-2.0.so.0
(gdb) bt
#0  0x4c91ad05 in gtk_tree_model_get_valist () from /usr/lib/libgtk-x11-2.0.so.0
#1  0x4c91aedc in gtk_tree_model_get () from /usr/lib/libgtk-x11-2.0.so.0
#2  0x0804ecf3 in on_modes_combo_changed (combobox=0x80a7828, user_data=0x0) at callbacks.c:164
#3  0x4d534bd7 in g_cclosure_marshal_VOID__VOID () from /usr/lib/libgobject-2.0.so.0
#4  0x080a6ab0 in ?? ()
#5  0xffffffff in ?? ()
#6  0x080ba4c8 in ?? ()
#7  0x4d5287c2 in g_closure_invoke () from /usr/lib/libgobject-2.0.so.0
#8  0xbf80723c in ?? ()
#9  0x00000000 in ?? ()

Let me know how if I can help you track down the bug.
Comment 1 Patrick Wagstrom 2007-12-17 19:21:49 UTC
Alexander,

Are you working off the main branch from freedesktop.org?  I've been maintaining an alternative branch with some updates, bug fixes, and UI changes that you may want to check out.  In particular, this sounds like one of the nasty bugs I squashed a while back.

Can you try pulling:

http://patrick.wagstrom.net/git/grandr.git

and seeing if the bug exists in that branch also?

Thanks!
Comment 2 Alexander Prinsier 2007-12-18 07:02:37 UTC
(In reply to comment #1)
> Alexander,
> 
> Are you working off the main branch from freedesktop.org?  I've been
> maintaining an alternative branch with some updates, bug fixes, and UI changes
> that you may want to check out.  In particular, this sounds like one of the
> nasty bugs I squashed a while back.
I was using the grandr that gentoo supplies in it's portage. It's probably the main branch.
> 
> Can you try pulling:
> 
> http://patrick.wagstrom.net/git/grandr.git
> 
> and seeing if the bug exists in that branch also?
I did, and this particular bug seems to be fixed there yes.

Just as a sidenote: grandr was acting 'strange' a few times. Eg the 'off' checkbox of my vga output just get's checked again for no reason. When both outputs are enabled, only my lcd screen is available in the 'layout' tab. The 'extend' combo box is always disabled, etc.

Suppose I'd want to take a peek at the code, what would be the best branch to work on and potentially make a patch from?
Comment 3 Priit Laes (irc: plaes) 2008-01-09 01:43:48 UTC
Created attachment 13607 [details] [review]
grandr-fix-crash-on-inactive-display.patch
Comment 4 Marc Geldon 2008-01-16 06:26:33 UTC
I have a similar problem with grandr. If I click on a screen icon, grandr crashes:

(grandr:11208): Gtk-CRITICAL **: gtk_list_store_get_value: assertion `VALID_ITER (iter, list_store)' failed

(grandr:11208): GLib-GObject-WARNING **: /build/buildd/glib2.0-2.14.1/gobject/gtype.c:3339: type id `0' is invalid

(grandr:11208): GLib-GObject-WARNING **: can't peek value table for type `<invalid>' which is not currently referenced
Segmentation fault (core dumped)

I am using Ubuntu 7.10. I've installed the package "grandr" (version 0.1-2) via Synaptic.
Comment 5 Paulo Zanoni 2010-01-27 10:12:54 UTC
First question: is grandr officially dead? Or just unmaintained?

I had a bug report for grandr in Mandriva so I started looking at it...

Repository on comment #1 is 404 not found.

Debian also has a patch for this bug:
http://git.debian.org/?p=pkg-xorg/app/grandr.git;a=commit;h=aa3cc75d642d0a2b8fb9edf4e0af71b3ab5f660c

Mandriva has re-diffed this patch, which will make it apply upstream:
http://svn.mandriva.com/cgi-bin/viewvc.cgi/packages/cooker/grandr/current/SOURCES/grandr-debian-01-fix-segfault-when-click-monitor.patch?view=markup

I also made another patch (read its header for a description of the problem):
http://svn.mandriva.com/cgi-bin/viewvc.cgi/packages/cooker/grandr/current/SOURCES/grandr-mandriva-synchronize-before-and-after-apply.patch?revision=496768&view=markup

If you want, you may apply these 2 patches upstream. If you think grandr should die, we will consider removing it from the distros =)
Comment 6 Jeremy Huddleston Sequoia 2011-10-08 13:13:01 UTC
Patrick, grandr isn't really maintained any more. Are you still maintaining 
your git repo?  Should we just merge your changes in?  Do you want to maintain 
the one hoseted at fd.o?
Comment 7 Patrick Wagstrom 2011-10-20 07:12:53 UTC
I haven't done anything with grandr in a couple of years. Ubuntu eventually got a much better display management app and I abandoned it. Therefore, from my perspective, it's unmaintained/abandoned. I don't intend on picking it up in the future.
Comment 8 GitLab Migration User 2018-08-10 20:33:04 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/xorg/app/xrandr/issues/2.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.