Bug 14020 - Use of GNU make extensions in some Makefile.am
Summary: Use of GNU make extensions in some Makefile.am
Status: RESOLVED FIXED
Alias: None
Product: Telepathy
Classification: Unclassified
Component: general (show other bugs)
Version: unspecified
Hardware: Other All
: medium minor
Assignee: Telepathy bugs list
QA Contact: Telepathy bugs list
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-01-11 05:00 UTC by Luca Ferretti
Modified: 2008-02-26 05:32 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:

Attachments
Add -Wno-portability to autoreconf in autogen.sh (131 bytes, patch)
2008-01-11 06:58 UTC, Luca Ferretti 		Details | Splinter Review
View All

Description Luca Ferretti 2008-01-11 05:00:22 UTC 
Automake 1.10 reports following warnings


docs/Makefile.am:6: `%'-style pattern rules are a GNU make extension
extensions/Makefile.am:37: wildcard *.xml: non-POSIX variable name
extensions/Makefile.am:37: (probably a GNU make extension)
extensions/Makefile.am: installing `./depcomp'
src/Makefile.am:152: `%'-style pattern rules are a GNU make extension
src/Makefile.am:153: subst -,_,$*: non-POSIX variable name
src/Makefile.am:153: (probably a GNU make extension)
src/Makefile.am:155: `%'-style pattern rules are a GNU make extension
src/Makefile.am:156: subst -,_,$*: non-POSIX variable name
src/Makefile.am:156: (probably a GNU make extension)
src/Makefile.am:158: `%'-style pattern rules are a GNU make extension
src/Makefile.am:159: subst -,_,$*: non-POSIX variable name
src/Makefile.am:159: (probably a GNU make extension)
src/Makefile.am:161: `%'-style pattern rules are a GNU make extension
src/Makefile.am:162: subst -,_,$*: non-POSIX variable name
src/Makefile.am:162: (probably a GNU make extension)
src/Makefile.am:166: `%'-style pattern rules are a GNU make extension
src/Makefile.am:174: `%'-style pattern rules are a GNU make extension
tests/Makefile.am:100: `%'-style pattern rules are a GNU make extension
tests/Makefile.am:103: `%'-style pattern rules are a GNU make extension
Comment 1 Dafydd Harries 2008-01-11 05:26:56 UTC 
To be honest, I would rather require GNU make than try to change this. Presumably there's some way to turn these warnings off.
Comment 2 Luca Ferretti 2008-01-11 06:54:50 UTC 
From latest gst-plugins-good update in my jhbuild:

2008-01-10  Sebastian Dröge  <slomo@circular-chaos.org>

        * autogen.sh:
          Add -Wno-portability to the automake parameters to stop warnings
          about GNU make extensions being used. We require GNU make in almost
          every Makefile anyway.
Comment 3 Luca Ferretti 2008-01-11 06:58:10 UTC 
Created attachment 13657 [details] [review]
Add -Wno-portability to autoreconf in autogen.sh

It seems to work...
Comment 4 Simon McVittie 2008-02-18 07:08:18 UTC 
I think it's better to fix this by passing -Wno-portability to AM_INIT_AUTOMAKE in configure.ac, so Automake will disable these warnings on every run, not just the first.

We should make this change for all Telepathy packages that need GNU make (reassigning to 'general'), and we should document the requirement at the same time.

Patch for telepathy-glib coming soon to http://monkey.collabora.co.uk/tp-glib-smcv-trivia/
Comment 5 Simon McVittie 2008-02-26 05:32:10 UTC 
Fixed in Darcs for most projects.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.