Bug 14239 - text with non-black fill color don't show for cairo_win32_printing_surface
Summary: text with non-black fill color don't show for cairo_win32_printing_surface
Status: RESOLVED FIXED
Alias: None
Product: cairo
Classification: Unclassified
Component: win32 backend (show other bugs)
Version: 1.5.6
Hardware: x86 (IA32) Windows (All)
: medium major
Assignee: cairo-bugs mailing list
QA Contact: cairo-bugs mailing list
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-01-24 19:04 UTC by bounin
Modified: 2008-01-24 19:10 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments

Description bounin 2008-01-24 19:04:58 UTC
If one of the color components for fill color is not zero it is converted to one and does not show on white background which is usual for printing. Looks like spy ink. Can be seen only on non-white background

Fix: in _cairo_win32_printing_surface_show_glyphs() function for the block when source->type == CAIRO_PATTERN_TYPE_SOLID

replace the line 
opaque = cairo_pattern_create_rgb (GetRValue (color), GetGValue (color), GetBValue (color));
with
opaque = cairo_pattern_create_rgb (GetRValue (color)/255., GetGValue (color)/255., GetBValue (color)/255.);

arguments should be double in range 0.0-1.0
Comment 1 Adrian Johnson 2008-01-24 19:10:32 UTC
This was fixed about 7 hours ago:

http://gitweb.freedesktop.org/?p=cairo;a=commit;h=b96c6c26c2d6b0b5f79ee569ece602338c4146b2


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.