Bug 14256 - AlwaysCore/SendCoreEvents broken
Summary: AlwaysCore/SendCoreEvents broken
Status: RESOLVED FIXED
Alias: None
Product: xorg
Classification: Unclassified
Component: Server/General (show other bugs)
Version: git
Hardware: All All
: medium major
Assignee: Xorg Project Team
QA Contact: Xorg Project Team
URL: http://gitweb.freedesktop.org/?p=xorg...
Whiteboard:
Keywords: janitor, regression
Depends on:
Blocks:
 
Reported: 2008-01-26 07:17 UTC by Jan Kandziora
Modified: 2008-01-28 15:45 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments

Description Jan Kandziora 2008-01-26 07:17:43 UTC
Somewhere between 7.0 and the current state, the handling of the "AlwaysCore", "SendCoreEvents", "CoreKeyboard", and "CorePointer" config options in xorg.conf was broken. See xorg-server-1.4/hw/xfree86/common/xf86Xinput.c

 115 xf86ProcessCommonOptions(LocalDevicePtr local,
 116                          pointer        list)
 117 {
 118     if (xf86SetBoolOption(list, "AlwaysCore", 0) ||
 119         !xf86SetBoolOption(list, "SendCoreEvents", 1) ||
 120         !xf86SetBoolOption(list, "CorePointer", 1) ||
 121         !xf86SetBoolOption(list, "CoreKeyboard", 1)) {
 122         xf86Msg(X_CONFIG, "%s: doesn't report core events\n", local->name);
 123     } else {
 124         local->flags |= XI86_ALWAYS_CORE;
 125         xf86Msg(X_CONFIG, "%s: always reports core events\n", local->name);
 126     }
 127 
...

If one uses the "AlwaysCore" option in an "Section InputDevice", the comparison above evaluates to *true* and such, XI86_ALWAYS_CORE is *not* set!

In 7.0, this option handling was correct.
Comment 1 Peter Hutterer 2008-01-28 15:45:27 UTC
Thanks, pushed as 5b8641a5fdc112c19e78ca2954878712e328d403


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.