Bug 14400 - patch to allow xman to use bzip to decompress man pages.
Summary: patch to allow xman to use bzip to decompress man pages.
Status: RESOLVED FIXED
Alias: None
Product: xorg
Classification: Unclassified
Component: App/xman (show other bugs)
Version: unspecified
Hardware: All other
: medium normal
Assignee: Xorg Project Team
QA Contact: Xorg Project Team
URL:
Whiteboard:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2008-02-06 01:41 UTC by Bob Raitz
Modified: 2008-02-12 03:29 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments
patch to provide bzip decompression support for xman (4.25 KB, text/plain)
2008-02-06 01:41 UTC, Bob Raitz
pappy_mcfae: 6.8-branch?
pappy_mcfae: 6.9/7.0?
Details

Description Bob Raitz 2008-02-06 01:41:15 UTC
Created attachment 14170 [details]
patch to provide bzip decompression support for xman

I am a Gentoo Linux user. Gentoo uses bzip to compress its manpages. Since xman doesn't support bzip, the manpages open as gibberish. The patch included in this bug report has been tested by myself, and it is provides the needed functionality. I submitted this bug to Gentoo's bugzilla, and was told I should send the patch upstream for consideration. 

I have installed the patch manually, and it works as expected. The bug is well documented at this link:
https://bugs.gentoo.org/show_bug.cgi?id=208827
Comment 2 Bob Raitz 2008-02-06 01:57:53 UTC
Just to be a bit more specific, I am using xman version 1.0.2.; the latest stable version in the Gentoo portage tree.
Comment 3 James Cloos 2008-02-09 12:14:40 UTC
I’m looking into this.

The patch does not (completely) apply to the current git master, and some of the changes between the version the patch is based on and master are such that porting the patch will take a bit of thought and care.

While I’m at it, I’ll also look into adding .lzma support, since on Gentoo ~x86, at least, man now saves the cat files compressed with lzma-utils’ version of lzma.

If you have any thoughts on the changes in xman/misc.c in particular, please post them.
Comment 4 Bob Raitz 2008-02-09 12:57:34 UTC
(In reply to comment #3)
> I’m looking into this.
> 
> The patch does not (completely) apply to the current git master, and some of
> the changes between the version the patch is based on and master are such that
> porting the patch will take a bit of thought and care.
> 
> While I’m at it, I’ll also look into adding .lzma support, since on Gentoo
> ~x86, at least, man now saves the cat files compressed with lzma-utils’
> version of lzma.
> 
> If you have any thoughts on the changes in xman/misc.c in particular, please
> post them.
> 

It may not completely apply to your git at this point, but it definitely applies to the Gentoo portage tree as it is of today (02-09-2008 ). 

The patch does work. I have it installed on all three of my machines.

This patch was reported to the Gentoo bugzilla. I was asked to pass it upstream for your consideration. I ask that you consider accepting this patch so that it can be used by Gentoo users downstream. That way, there will be a resolution on the Gentoo bugzilla.

Oh, and for the record, I'm not the original author of the patch in question. I'm also not a programmer in C, although I have played a bit with c++ and scripting. I just happened to run across the patch in a Gentoo forum, installed it manually, and found it useful.

Thank you for your time and consideration.

Blessed be!
Pappy
Comment 5 James Cloos 2008-02-09 19:03:36 UTC
I wasn’t questioning whether it works, I trusted that it did.

patch(1) was unable to apply it, and the #ifdefs in those files (to deal with the variations in where man pages are stored in the numerous systems xman(1x) supports) are more than a bit hairy.  

But I was able to apply it by hand in commit dbfa16889ae66d5880e23c9a63f8385896512020.

You can expect it to be included in xman 1.0.4.

I’ll add a comment to that effect to the gentoo bug as well.
Comment 6 Bob Raitz 2008-02-09 23:59:10 UTC
(In reply to comment #5)
> I wasn’t questioning whether it works, I trusted that it did.
> 
> patch(1) was unable to apply it, and the #ifdefs in those files (to deal with
> the variations in where man pages are stored in the numerous systems xman(1x)
> supports) are more than a bit hairy.  
> 
> But I was able to apply it by hand in commit
> dbfa16889ae66d5880e23c9a63f8385896512020.
> 
> You can expect it to be included in xman 1.0.4.
> 
> I’ll add a comment to that effect to the gentoo bug as well.
> 

Thank you very much, and if you need a volunteer to test it, I have three Gentoo systems ready and waiting to try it.

Thanks for your time and consideration.

Blessed be!
Pappy
Comment 7 James Cloos 2008-02-11 17:51:22 UTC
(In reply to comment #6)
> Thank you very much, and if you need a volunteer to test it, I have three
> Gentoo systems ready and waiting to try it.

To test it you can clone the xman git repo via:

git://anongit.freedesktop.org/git/xorg/app/xman

or

http://anongit.freedesktop.org/git/xorg/app/xman

and run:

 ./autogen.sh && make && sudo make install

Or, for a Gentoo box you can clone my as yet partial live-x11 overlay via:

git://people.freedesktop.org/~cloos/live-x11.git

or

http://people.freedesktop.org/~cloos/live-x11.git

or, if you just want the single ebuild you can grab that via cgit at:

http://cgit.freedesktop.org/~cloos/live-x11/tree/x11-apps/xman/xman-9999.ebuild

for an HTML page or, for just the text/plain file:

http://cgit.freedesktop.org/~cloos/live-x11/blob/?id=3562a073836d6cffc7a88b855a648bad3cda0e01

I’m running that now and it works fine for me.  (I do not use xprint so I haven’t tested the xprint support in xman.  But everything else was fine.)
Comment 8 Bob Raitz 2008-02-12 03:29:57 UTC
I finally got git to work...had to emerge it. 

The git version works as far as I can tell. Your ebuild came up as masked by corruption. 

Are there specific things you'd like me to test? There was a mention of lzma compression, vis a vis:

>While I’m at it, I’ll also look into adding .lzma support, since on Gentoo
>~x86, at least, man now saves the cat files compressed with lzma-utils’
>version of lzma.

What files are these? I'd like to test functionality in all ways.

Blessed be!
Pappy


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.