Bug 14680 - keep the primary selection in media dialog
Summary: keep the primary selection in media dialog
Status: RESOLVED NOTOURBUG
Alias: None
Product: swfdec
Classification: Unclassified
Component: plugin (show other bugs)
Version: git
Hardware: All Linux (All)
: medium normal
Assignee: swfdec ml
QA Contact: swfdec ml
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-02-26 04:15 UTC by Sylvain BERTRAND
Modified: 2013-12-30 01:23 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
keep the primary selection in media dialog (2.24 KB, patch)
2008-05-27 02:29 UTC, Riccardo Magliocchetti
Details | Splinter Review
keep the primary selection in media dialog - try 2 (2.09 KB, patch)
2008-05-27 03:05 UTC, Riccardo Magliocchetti
Details | Splinter Review
keep the primary selection in media dialog - try 3 (2.60 KB, patch)
2008-08-16 12:05 UTC, Riccardo Magliocchetti
Details | Splinter Review

Description Sylvain BERTRAND 2008-02-26 04:15:40 UTC
I'm unable to save a .flv from the properties or copy-paste the link still from the properties in order to use wget to grab the file.
Comment 1 Pavel Roskin 2008-02-26 06:38:31 UTC
That's two different issues.  Copying the link works, but the widget used for the URL loses PRIMARY selection when it loses focus, so it only remains in the CLIPBOARD.

As a workaround, I added this to my .Xresources file:

*VT100*translations: #override \n\
 Shift Ctrl<Btn2Up>: insert-selection(CLIPBOARD, CUT_BUFFER1) \n\
 Shift Ctrl<KeyPress> Insert: insert-selection(CLIPBOARD, CUT_BUFFER1)

Now I can insert in xterm from CLIPBOARD with Ctrl-Shift-Insert or Ctrl-Shift-middle click.

I agree, having a more convenient "properties" dialog would be great, but it would have severity "enhancement".
Comment 2 Riccardo Magliocchetti 2008-05-23 05:47:53 UTC
I believe both of these issues are fixed in the last patch attached to bug 15958, if you can confirm i'll close this as duplicate.
Comment 3 Sylvain BERTRAND 2008-05-23 07:07:07 UTC
Applied patch try3 on git swfdec-mozilla. Still failing to copy video link from properties dialog box to a terminal for wget use.
BTW, in git swdec libs flash movies are play by default, how to disable this and make make flash movies *not* played by default?
Comment 4 Riccardo Magliocchetti 2008-05-23 08:09:12 UTC
(In reply to comment #3)
> Applied patch try3 on git swfdec-mozilla. Still failing to copy video link from
> properties dialog box to a terminal for wget use.

ok, i didn't understand the problem. The other clipboard (ctrl + c / ctrl + v) works fine.

> BTW, in git swdec libs flash movies are play by default, how to disable this
> and make make flash movies *not* played by default?
> 

In 0.7 there is a new autoplay feature, try to add to ~/.config/swfdec-mozilla.conf:

[global]
autoplay=false

and set autoplay to false to the other entries you have there.

If you have other questions please use the list.
Comment 5 Riccardo Magliocchetti 2008-05-27 02:29:46 UTC
Created attachment 16759 [details] [review]
keep the primary selection in media dialog

Attached a patch tha copy the selection in both PRIMARY and CLIPBOARD.

Please note that you have at least to click one item to fill the clipboard.

Patch requires attachment 16713 [details] [review] posted in bug 15960.
Comment 6 Riccardo Magliocchetti 2008-05-27 03:05:34 UTC
Created attachment 16760 [details] [review]
 keep the primary selection in media dialog - try 2

New revision: only handle PRIMARY, don't touch CLIPBOARD.
Comment 7 Sylvain BERTRAND 2008-05-27 03:45:02 UTC
Tried swfdec-mozilla (git) with attachment 16713 [details] [review] and attachment 16713 [details] [review]
Still unable to past in a terminal.
Comment 8 Riccardo Magliocchetti 2008-08-16 12:05:57 UTC
Created attachment 18323 [details] [review]
keep the primary selection in media dialog - try 3

So the problem was that the url field was editable, now the only way to cut is with primary selection just clicking on a row. If that is acceptable behaviour please apply.
Also a variable got renamed as in gtk documentation.
Comment 9 Benjamin Otte 2008-08-27 03:11:07 UTC
The biggest problem I have with this patch is that it's unintuitive. Selecting a row in a treeview does not repalce contents of the primary selection anywhere, right?
Comment 10 Riccardo Magliocchetti 2008-08-28 03:13:56 UTC
(In reply to comment #9)
> The biggest problem I have with this patch is that it's unintuitive. Selecting
> a row in a treeview does not repalce contents of the primary selection
> anywhere, right?

Yes it's not common usage but it's very handy. I'm not really an user of that feature myself so i've not a strong opinion.



Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.