Bug 14858 - Build fix for FreeBSD
Summary: Build fix for FreeBSD
Status: RESOLVED FIXED
Alias: None
Product: xorg
Classification: Unclassified
Component: Driver/nouveau (show other bugs)
Version: git
Hardware: x86-64 (AMD64) FreeBSD
: medium normal
Assignee: Nouveau Project
QA Contact: Xorg Project Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-03-06 11:39 UTC by Pawel Worach
Modified: 2010-03-27 05:45 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments
Fix (374 bytes, patch)
2008-03-06 11:39 UTC, Pawel Worach
no flags Details | Splinter Review

Description Pawel Worach 2008-03-06 11:39:12 UTC
nv_bios.c:26:22: error: byteswap.h: No such file or directory

bswap and friends are defined in endian.h (on freebsd) which is pulled in by X11/Xarch.h. This should fix the build on netbsd too.
Comment 1 Pawel Worach 2008-03-06 11:39:54 UTC
Created attachment 14884 [details] [review]
Fix
Comment 2 Stephane Marchesin 2008-07-17 16:18:46 UTC
Applied, thanks. Note that you still need fixes for the drm.
Comment 3 Brad Smith 2008-07-17 21:28:03 UTC
The patch is hackish at best. What should be done is copy the bits from the X server to properly detect the macros to use as was done with the Radeon driver recently..

http://gitweb.freedesktop.org/?p=xorg/driver/xf86-video-ati.git;a=commitdiff_plain;h=52459745ec05de88adbc087e9566fe6d97ef424b;hp=67a6ac0001bc9d062aa426384a11a41fa7a1c09a

http://gitweb.freedesktop.org/?p=xorg/driver/xf86-video-ati.git;a=commitdiff_plain;h=32e1d1daf4f68ea37624afaa2bc1ea7742e1163b;hp=dca522355a9039eca6efaba3b36397b246800f94

This will ensure proper portability and fix Nouveau on OpenBSD, DragonFlyBSD, Solaris and other OS's at least with regard to the endian swapping macros.
Comment 4 Brad Smith 2008-07-21 15:09:39 UTC
Reopened. Take note of the previous comment.
Comment 5 Stephane Marchesin 2008-07-22 05:00:46 UTC
(In reply to comment #4)
> Reopened. Take note of the previous comment.
> 

Sure, please feel free to send patches.
Comment 6 Francisco Jerez 2010-03-27 05:45:55 UTC
The DDX no longer depends on byteswap.h, nv_bios.c doesn't even exist anymore, closing...


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.