Bug 15718 - Display blanks momentarily when starting/stopping video playback
Summary: Display blanks momentarily when starting/stopping video playback
Status: RESOLVED FIXED
Alias: None
Product: xorg
Classification: Unclassified
Component: Driver/radeonhd (show other bugs)
Version: git
Hardware: Other All
: medium minor
Assignee: Egbert Eich
QA Contact: Xorg Project Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-04-25 22:23 UTC by druidic
Modified: 2008-04-28 11:41 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
My Xorg log (57.18 KB, text/plain)
2008-04-25 22:23 UTC, druidic
no flags Details
Bisect results (360 bytes, text/plain)
2008-04-28 06:28 UTC, druidic
no flags Details
Patch for testing. (6.73 KB, patch)
2008-04-28 09:57 UTC, Egbert Eich
no flags Details | Splinter Review
Xorg log after the patch (99.57 KB, text/plain)
2008-04-28 10:17 UTC, druidic
no flags Details
Additional patch. (524 bytes, patch)
2008-04-28 10:58 UTC, Egbert Eich
no flags Details | Splinter Review
Log after the additional patch (101.89 KB, text/plain)
2008-04-28 11:10 UTC, druidic
no flags Details

Description druidic 2008-04-25 22:23:05 UTC
Created attachment 16185 [details]
My Xorg log

X.org version:  1.4.0.90
Kernel version: 2.6.24
Driver version: 1.2.1, commit 6f34607b

The display blanks for a second or so when I start or stop watching video using mplayer. Sometimes the blanking is hardly noticeable, but on other times it is fairly annoying. I have a X1400 card.

When this occurs, the logs do not show anything out of the ordinary. This also did not happen in earlier git builds. I've yet to determine at which point the regression happened.
Comment 1 Egbert Eich 2008-04-28 01:53:15 UTC
We don't do anything special for video playback. There is not Xv extension in the driver, yet.
You may want to try out if turning off XAA helps there.
Put an 'Option "AccellMethod" "ShadowFb"
into the device section of your config file.
I would assume that this problem has something to do with the introduction of XAA.
If above test doesn't help please do a git-bisect to determine where this problem was introduced.
Assigning to reporter for feedback. Please assign back when done.
Comment 2 druidic 2008-04-28 06:28:45 UTC
Created attachment 16214 [details]
Bisect results
Comment 3 druidic 2008-04-28 06:29:33 UTC
Unfortunately setting

Option "AccelMethod" "ShadowFb"

did not help. I was able to do a bisect though.
Comment 4 Egbert Eich 2008-04-28 08:49:58 UTC
Cool, thanks for the bisect!
This indicates that mplayer is using DPMS otherwise the reset function for the output wouldn't be touched.
Comment 5 druidic 2008-04-28 09:02:14 UTC
Glad I could help. Git seems to be a handy tool - bisecting was a breeze. Can you figure out some resolution for this? Or is it even fixable?
Comment 6 Adam Williamson 2008-04-28 09:17:48 UTC
mplayer inhibits the screensaver when you're playing video with it; I suspect that's why it touches DPMS.
Comment 7 Alex Deucher 2008-04-28 09:32:27 UTC
this looks like the same issue as bug 14869
Comment 8 druidic 2008-04-28 09:34:40 UTC
Could be. Just to verify your suspicions. I ran "xset -dpms" before mplayer and no blanking. The action of disabling DPMS causes the aforementioned effect though.
Comment 9 Egbert Eich 2008-04-28 09:57:36 UTC
Created attachment 16221 [details] [review]
Patch for testing.

Thanks for testing! I've attached a patch which adds
a. more detailed debugging output for '-logverbose 7' mode.
b. attempts to fix this problem.

The change which caused the problem adds a full output pll reset and data resync. This would not be required in the POWER_RESET state when only the output line drivers are off.
The old code did the reset in the Set() code, however it is required whenever we return from POWER_SHUTDOWN and there is nothing that would guarantee that there is always a call to Set() before.
If you don't mind, could you please test this patch for me? Thanks!
Comment 10 druidic 2008-04-28 10:17:19 UTC
Sure. I ran the patch and X starts just fine, but with the display blanked.
I'll attach my log.
Comment 11 druidic 2008-04-28 10:17:56 UTC
Created attachment 16222 [details]
Xorg log after the patch
Comment 12 Egbert Eich 2008-04-28 10:58:36 UTC
Created attachment 16224 [details] [review]
Additional patch.

I think I know where the problem is.
Could you please try this patch on top?
Comment 13 druidic 2008-04-28 11:09:44 UTC
Great! It seems to work. No more blanking with mplayer. I started and stopped playback a few times as shown in the log after

"SetClientVersion: 0 9".
Comment 14 druidic 2008-04-28 11:10:10 UTC
Created attachment 16226 [details]
Log after the additional patch
Comment 15 Egbert Eich 2008-04-28 11:41:41 UTC
Cool! Thanks for testing!
Fix committed.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.