Bug 15914 - -ati needs support for ATI xpress 1250 hw
Summary: -ati needs support for ATI xpress 1250 hw
Status: RESOLVED FIXED
Alias: None
Product: xorg
Classification: Unclassified
Component: Driver/Radeon (show other bugs)
Version: 7.3 (2007.09)
Hardware: All Linux (All)
: high normal
Assignee: xf86-video-ati maintainers
QA Contact: Xorg Project Team
URL: https://bugs.launchpad.net/ubuntu/int...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-05-12 16:10 UTC by Bryce Harrington
Modified: 2008-05-14 10:44 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments
Add pci id support for xpress 1250 (2.81 KB, patch)
2008-05-12 16:21 UTC, Bryce Harrington
no flags Details | Splinter Review
possible patch (13.16 KB, patch)
2008-05-12 17:34 UTC, Alex Deucher
no flags Details | Splinter Review
log using ati driver from git with Alex's patch applied (43.02 KB, patch)
2008-05-13 02:37 UTC, Antoine Pairet
no flags Details | Splinter Review
xorg configuration file, using ati driver (1.53 KB, text/plain)
2008-05-13 02:38 UTC, Antoine Pairet
no flags Details
same as above, but with text/plain as myme type so it can be viewed without downloading (43.02 KB, text/plain)
2008-05-13 02:40 UTC, Antoine Pairet
no flags Details
alternate patch (13.06 KB, patch)
2008-05-13 05:26 UTC, Alex Deucher
no flags Details | Splinter Review
Xorg log when succesfully using radeon driver on X1250 chip (45.93 KB, text/plain)
2008-05-13 11:39 UTC, Antoine Pairet
no flags Details

Description Bryce Harrington 2008-05-12 16:10:33 UTC
PCI ID 1002:7942 "ATI Xpress 1250" is not listed in ati_pciids_gen.h, so users with this motherboard must use the -radeonhd or -fglrx driver.  

Is it as simple as adding the pci id to this file, or is additional work required to support it?

http://launchpadlibrarian.net/13577403/Xorg.0.log.old
http://launchpadlibrarian.net/13577413/dmesg.log
http://launchpadlibrarian.net/13577420/lspci.log
Comment 1 Bryce Harrington 2008-05-12 16:21:41 UTC
Created attachment 16493 [details] [review]
Add pci id support for xpress 1250

I don't know if more is required than to just add the pci id, but here's a go at that.
Comment 2 Alex Deucher 2008-05-12 17:34:50 UTC
Created attachment 16494 [details] [review]
possible patch

It'll need more than just ids.  The memory controller has changed substantially.  Does this patch work?
Comment 3 Antoine Pairet 2008-05-12 23:21:25 UTC
Hi, 
I have a X1250 and like to test Alex's patch, can someone explain me how to apply this patch (Ubuntu Hardy Heron).
Thanks in adavance,
Comment 4 Bryce Harrington 2008-05-13 00:01:55 UTC
@Antoine, you'll need to build the -ati driver from git and apply the patch.

Alex, any chance of a patch that applies against 6.8.0?  Looks like the code this one modifies has changed fairly substantially since 6.8.0 so maybe not, but if so it might be backportable to Hardy.
Comment 5 Antoine Pairet 2008-05-13 02:35:53 UTC
Hi,
I pulled the latest sources from git:
git-clone git://anongit.freedesktop.org/git/xorg/driver/xf86-video-ati

Then I applied the patch:
patch --verbose -uN < alex_deucher.diff

The patch applied succesfully (had to enter manually the path to the files to patch)
Then I edited my xorg.conf file and set the ati driver, then I restarted X and the computer crashed. I had to restart by pressing Ctrl+Alt+Delete.
In the Xorg.0.log:
(EE) RADEON(0): Timeout trying to update memory controller settings !
(EE) RADEON(0): You will probably crash now ...

I'll attach this log and my xorg.conf,
regards,
Antoine
Comment 6 Antoine Pairet 2008-05-13 02:37:07 UTC
Created attachment 16503 [details] [review]
log using ati driver from git with Alex's patch applied
Comment 7 Antoine Pairet 2008-05-13 02:38:38 UTC
Created attachment 16504 [details]
xorg configuration file, using ati driver
Comment 8 Antoine Pairet 2008-05-13 02:40:24 UTC
Created attachment 16505 [details]
same as above, but with text/plain as myme type so it can be viewed without downloading
Comment 9 Alex Deucher 2008-05-13 05:26:19 UTC
Created attachment 16507 [details] [review]
alternate patch

Can you try this one?  You'll want to apply with -p1:
patch -p1 -i rs600-2.diff
Comment 10 Antoine Pairet 2008-05-13 11:38:34 UTC
(In reply to comment #9)
> Created an attachment (id=16507) [details]
> alternate patch
> 
> Can you try this one?  You'll want to apply with -p1:
> patch -p1 -i rs600-2.diff
> 

Great!
Thanks for the good job, Alex's second patch works. I'm now able to run the radeon driver.

The only error I see in Xorg.0.log is:
(EE) RADEON(0): [dri] RADEONDRIGetVersion failed to open the DRM
[dri] Disabling DRI.

Next step is to know whether it will possible to apply this patch to version 6.8.0 (Ubuntu Hardy's version) 
If you need information like the .rej files when I try to apply the patch to the package's source from Hardy depot, feel free to ask!

regards,
Antoine
Comment 11 Antoine Pairet 2008-05-13 11:39:38 UTC
Created attachment 16510 [details]
Xorg log when succesfully using radeon driver on X1250 chip
Comment 12 Alex Deucher 2008-05-13 12:52:37 UTC
(In reply to comment #10)
> Great!
> Thanks for the good job, Alex's second patch works. I'm now able to run the
> radeon driver.
> 

Excellent!

> The only error I see in Xorg.0.log is:
> (EE) RADEON(0): [dri] RADEONDRIGetVersion failed to open the DRM
> [dri] Disabling DRI.
> 

The drm will need some work to support the RS600.
Comment 13 Alex Deucher 2008-05-14 10:44:14 UTC
Committed: 71fa57f871dba03260dba2180ce1dab44048ac1a


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.