Bug 16027 - xdg-screensaver doesn't support preferences GUI
Summary: xdg-screensaver doesn't support preferences GUI
Status: RESOLVED INVALID
Alias: None
Product: Portland
Classification: Unclassified
Component: xdg-utils (show other bugs)
Version: unspecified
Hardware: All All
: medium normal
Assignee: Portland Bugs
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-05-19 18:21 UTC by Brian Cameron
Modified: 2015-01-04 22:15 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments

Description Brian Cameron 2008-05-19 18:21:19 UTC
The gnome-panel code (in gnome-panel/panel-util.c) has hardcoded references to the screensaver programs.  It seems it would be be good to get rid of the hardcoded references to gnome-screensaver/xscreensaver commands and instead just use xdg-screensaver.  However note that gnome-panel also needs to run the preferences GUI program for the screensaver, so the preferences programs (gnome-screensaver-preferences and xscreensaver-demo) are also hardcoded.  However xdg-screensaver does not support any options to launch the preferences GUI for the appropriate screensaver.

I think it would make sense for xdg-screensaver to support an option (perhaps "-prefs") that would just launch the appropriate preferences GUI program.  This way we could get rid of hardcoding the screensaver and screensaver preferences GUI commands in the panel code.

Below I am showing the code in gnome-panel which shows the hardcoding of the screensaver command and the screensaver preferences GUI command.

----

        if (panel_is_program_in_path ("gnome-screensaver-command")
            && panel_is_program_in_path ("gnome-screensaver-preferences"))
                use_gscreensaver = TRUE;
        else if (!panel_is_program_in_path ("xscreensaver-command"))
                return NULL;

        if (strcmp (action, "prefs") == 0) {
                if (use_gscreensaver) {
                        command = g_strdup ("gnome-screensaver-preferences");
                } else if (panel_is_program_in_path ("xscreensaver-demo")) {
                        command = g_strdup ("xscreensaver-demo");
                } else {
                        command = NULL;
                }
Comment 1 Reuben Thomas 2015-01-04 21:41:11 UTC
GNOME no longer supports a screensaver; this issue can be closed.
Comment 2 Rex Dieter 2015-01-04 22:15:49 UTC
OK, closing.

We'll likely implement some sort of plugable architecture for future/feature xdg-utils releases that could support the idea expressed in the original report.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.