Bug 16209 - Cairo from git causes openoffice to lack glyphs
Summary: Cairo from git causes openoffice to lack glyphs
Status: RESOLVED NOTOURBUG
Alias: None
Product: cairo
Classification: Unclassified
Component: general (show other bugs)
Version: 1.6.5
Hardware: Other All
: medium normal
Assignee: Behdad Esfahbod
QA Contact: cairo-bugs mailing list
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-06-02 18:06 UTC by Ben Gamari
Modified: 2008-09-29 09:02 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
Screenshot of openoffice with no text (98.66 KB, image/png)
2008-06-02 18:07 UTC, Ben Gamari
Details

Description Ben Gamari 2008-06-02 18:06:43 UTC
Openoffice can draw no text on git cairo. Bisection shows the first bad commit is,

ben@mercury /opt/exp/cairo $ git bisect bad
a30209402c7160af257e1ea027e9e2cdab5b5aec is first bad commit
commit a30209402c7160af257e1ea027e9e2cdab5b5aec
Author: Behdad Esfahbod <behdad@behdad.org>
Date:   Sat May 24 14:57:56 2008 -0400

    [cairo-gstate] Drop glyphs out of surface boundaries in show_glyphs()
Comment 1 Ben Gamari 2008-06-02 18:07:38 UTC
Created attachment 16880 [details]
Screenshot of openoffice with no text
Comment 2 Behdad Esfahbod 2008-06-02 18:40:55 UTC
I see this myself but didn't get to debug.

Will look into it tonight.
Comment 3 Behdad Esfahbod 2008-06-02 19:33:13 UTC
Ughh... It's openoffice.org lying about the size of drawable.  Always passes 1x1:

+    cairo_surface_t *surface = rCairo.xlib_surface_create_with_xrender_format (pDisplay,
+        hDrawable_, DefaultScreenOfDisplay(pDisplay), pVisualFormat, 1, 1);


In this function:
http://www.google.com/codesearch?hl=en&q=+X11SalGraphics::DrawCairoAAFontString+show:_B6qrHMJ8tY:DJOsiSbA1JE:_B6qrHMJ8tY&sa=N&cd=1&ct=rc&cs_p=svn://svn.gnome.org/svn/ooo-build/trunk&cs_f=patches/src680/ooo85470.workspace.cairotext01.diff#l329

ughh..

Going to special-case it or something :(.
Comment 4 Behdad Esfahbod 2008-06-02 19:39:59 UTC
From what I can see debugging, the clip region it sets is bogus too.  I'm getting 1x1 surface extents, and 0x0 intersection of surface and clip extents.
Comment 5 Ben Gamari 2008-06-02 21:36:39 UTC
Are you going to open an openoffice bug? This seems like a pretty serious abuse of the API.
Comment 6 Behdad Esfahbod 2008-06-02 22:06:43 UTC
(In reply to comment #5)
> Are you going to open an openoffice bug? This seems like a pretty serious abuse
> of the API.

This seems to be coming from the ooo-build tree, not "upstream".  I already wrote to our ooo hacker at Red Hat.  I'm sure he'll take some care of it.  Will update here.

Which distro are you using?   I'm hoping that this is new enough to be easy to get fixed and propagated in time.
Comment 7 Ben Gamari 2008-06-02 22:18:26 UTC
I'm on Gentoo with a few packages from git/svn/[insert vcs here].
Comment 8 Ben Gamari 2008-06-19 08:16:50 UTC
What is the status of this?

(In reply to comment #7)
> I'm on Gentoo with a few packages from git/svn/[insert vcs here].
> 

Comment 9 Behdad Esfahbod 2008-06-19 08:44:15 UTC
I think Fedora 9 has got a fixed OO.o package.  It's really hard to work around it in cairo.  Bug your OO.o maintainer to check the Fedora OO.o package out.  The code in question is OO.o 3 code that distros have backported to 2.
Comment 10 Chris Wilson 2008-09-29 09:02:52 UTC
Time has passed and with new OO.o packages available and no further reports of distress, I feel safe in finally closing this bug report...


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.