Bug 16473 - regression: cannot have external monitor above laptop panel anymore
Summary: regression: cannot have external monitor above laptop panel anymore
Status: RESOLVED FIXED
Alias: None
Product: xorg
Classification: Unclassified
Component: Driver/radeonhd (show other bugs)
Version: git
Hardware: x86 (IA32) Linux (All)
: medium normal
Assignee: Egbert Eich
QA Contact: Xorg Project Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-06-23 03:48 UTC by Peter Van Eynde
Modified: 2008-07-30 22:34 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
Xorg.log file with the non-working version (122.14 KB, text/plain)
2008-06-23 03:48 UTC, Peter Van Eynde
no flags Details
Xorg.log with the working version (108.86 KB, application/octet-stream)
2008-06-23 03:48 UTC, Peter Van Eynde
no flags Details
xrandr -q before changing the resolution and moving the external display (496 bytes, text/plain)
2008-06-23 03:49 UTC, Peter Van Eynde
no flags Details
xrandr output after the switch (499 bytes, text/plain)
2008-06-23 03:55 UTC, Peter Van Eynde
no flags Details
xrandr -q --verbose output with git HEAD before uncloning displays (9.25 KB, text/plain)
2008-06-23 22:19 UTC, Peter Van Eynde
no flags Details
xrandr -q --verbose output with git HEAD after uncloning displays (9.19 KB, text/plain)
2008-06-23 22:19 UTC, Peter Van Eynde
no flags Details
Xorg.0.log with Option "AccelMethod" "shadowfb" (175.78 KB, text/plain)
2008-06-23 22:20 UTC, Peter Van Eynde
no flags Details
current xorg.conf with Option "AccelMethod" "shadowfb" (3.24 KB, text/plain)
2008-06-23 22:21 UTC, Peter Van Eynde
no flags Details
Test with git commit b0f470aa (164.60 KB, application/x-gzip)
2008-07-28 03:21 UTC, Peter Van Eynde
no flags Details
New test with git commit 996d309f (136.31 KB, application/x-gzip)
2008-07-29 23:50 UTC, Peter Van Eynde
no flags Details
Test code. (3.27 KB, patch)
2008-07-30 05:16 UTC, Egbert Eich
no flags Details | Splinter Review
typescript with extra debugs (81.24 KB, application/x-gzip)
2008-07-30 07:32 UTC, Peter Van Eynde
no flags Details
Possible fix. (1.88 KB, patch)
2008-07-30 09:26 UTC, Egbert Eich
no flags Details | Splinter Review

Description Peter Van Eynde 2008-06-23 03:48:08 UTC
Created attachment 17316 [details]
Xorg.log file with the non-working version

Hi,

In all version after git commit 566ba690de22f60059e9aee1b6b942088b3b6f01 I cannot move my external display above my panel interface.

With the working version I just use:

xrandr --output VGA_1 --above PANEL  --mode 1440x900

with the non-working version the screen flashes and then X crashes with a sig 11.
Comment 1 Peter Van Eynde 2008-06-23 03:48:49 UTC
Created attachment 17317 [details]
Xorg.log with the working version
Comment 2 Peter Van Eynde 2008-06-23 03:49:22 UTC
Created attachment 17318 [details]
xrandr -q before changing the resolution and moving the external display
Comment 3 Peter Van Eynde 2008-06-23 03:55:49 UTC
Created attachment 17319 [details]
xrandr output after the switch
Comment 4 Egbert Eich 2008-06-23 14:20:45 UTC
The commit has nothing to do with where the crash (according to the log file) actually happens.
The commit actually dealt with PLL assignments while the log claimed that the crash happened somewhere in the fb code (underneath the xaa wrapper).

Please try:
Option "AccelMethod" "shadowfb"

for testing.
Comment 5 Peter Van Eynde 2008-06-23 22:18:58 UTC
Thanks. I tried this and now there is no crash anymore. I see:

pevaneyn@sharrow:~ :) $ xrandr -q --verbose > xrandr-q-verbose-before
pevaneyn@sharrow:~ :( $ xrandr --output VGA_1 --above PANEL
xrandr: Configure crtc 0 failed
pevaneyn@sharrow:~ :( $ xrandr --output VGA_1  --mode 1440x900
pevaneyn@sharrow:~ :) $ xrandr -q --verbose > xrandr-q-verbose-after
pevaneyn@sharrow:~ :) $ xrandr --version
Server reports RandR version 1.2

I'm attaching the two xrandr output files, the xorg.conf file and the Xorg.log file.
Comment 6 Peter Van Eynde 2008-06-23 22:19:36 UTC
Created attachment 17342 [details]
xrandr -q --verbose output with git HEAD before uncloning displays
Comment 7 Peter Van Eynde 2008-06-23 22:19:56 UTC
Created attachment 17343 [details]
xrandr -q --verbose output with git HEAD after uncloning displays
Comment 8 Peter Van Eynde 2008-06-23 22:20:40 UTC
Created attachment 17344 [details]
Xorg.0.log with Option "AccelMethod" "shadowfb"
Comment 9 Peter Van Eynde 2008-06-23 22:21:34 UTC
Created attachment 17345 [details]
current xorg.conf with Option "AccelMethod" "shadowfb"
Comment 10 Egbert Eich 2008-07-21 09:10:14 UTC
Peter, I cannot reproduce this - it works here without any problems.
The result is the expected one and I don't get an error like:
> pevaneyn@sharrow:~ :( $ xrandr --output VGA_1 --above PANEL
> xrandr: Configure crtc 0 failed
  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
I've added some more debugging stuff to the driver. Please refetch the driver, run X in verbose 7 mode and re-execute the command sequence to bring the panel above the VGA_1 display.
The failure should show in the log file. Please attach the resulting log.
Thanks!
Comment 11 Peter Van Eynde 2008-07-28 03:21:14 UTC
Created attachment 17927 [details]
Test with git commit b0f470aa

Hello, sorry for the delay: I was on holiday.

I've taken the debugs I think, please see the attached (edited) typescript with the commands and the logoutput of the X server.

If you need anything more do not hesitate to ask.

Best regards, Peter
Comment 12 Egbert Eich 2008-07-29 05:29:42 UTC
In the log file I see these lines:

(II) RADEONHD(0): FUNCTION: rhdModeValidateCrtc
(II) RADEONHD(0): rhdRROutputModeFixup: 1024x768 FAILED: [0xe] no clock available for mode
(II) RADEONHD(0): rhdRROutputDpms: Output PANEL : Off

I think I know what the problem is here. I will prepare a patch.
Comment 13 Egbert Eich 2008-07-29 14:09:51 UTC
I've just pushed a bunch of fixes. Please retest. I might have found the issue that's causing the problem seen in the previous commit.
Comment 14 Peter Van Eynde 2008-07-29 23:50:45 UTC
Created attachment 17988 [details]
New test with git commit 996d309f

Hi

I retried and the problem remains. I've repeated the tests and attached the logs again. It seems the T60 is a difficult customer :-(.

Best regards, Peter
Comment 15 Egbert Eich 2008-07-30 05:15:00 UTC
OK, I cannot reproduce this here and there seems to be a plethora of Xservers with slightly different behavior of the RandR layer around.
The only way I can find out what's going on here is to clutter teh code with a load of debug messages. Maybe I should provide you with a patch directly.
Comment 16 Egbert Eich 2008-07-30 05:16:14 UTC
Created attachment 17999 [details] [review]
Test code.
Comment 17 Peter Van Eynde 2008-07-30 07:32:58 UTC
Created attachment 18001 [details]
typescript with extra debugs

Hello again,

I ran the tests again with your extra debugs and attached the results.

Best regards, Peter.
Comment 18 Egbert Eich 2008-07-30 09:26:32 UTC
Created attachment 18006 [details] [review]
Possible fix.

Peter, could you please try if this fixes your problem? This patch should apply on top of the previous one. Thanks!
Comment 19 Peter Van Eynde 2008-07-30 22:34:47 UTC
Hello Egbert,

The patches work. I can now enable my external screen and use the laptop panel at the same time.

Thanks!

I'll now again track HEAD and report if it should break again.

Best regards, Peter


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.