Bug 16564 - _surfaces_compatible can return true for different picture formats
Summary: _surfaces_compatible can return true for different picture formats
Status: RESOLVED FIXED
Alias: None
Product: cairo
Classification: Unclassified
Component: xlib backend (show other bugs)
Version: 1.6.5
Hardware: All Linux (All)
: medium minor
Assignee: Carl Worth
QA Contact: cairo-bugs mailing list
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-06-29 17:42 UTC by Karl Tomlinson
Modified: 2008-09-28 10:01 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
patch (2.01 KB, patch)
2008-06-29 17:42 UTC, Karl Tomlinson
Details | Splinter Review

Description Karl Tomlinson 2008-06-29 17:42:16 UTC
Created attachment 17453 [details] [review]
patch

_surfaces_compatible in cairo-xlib-surface returns true for surfaces with
different xrender_format when each has the same depth and no (NULL) visual.

Common picture formats will not have the same depth, but
it is possible to create a surface with a non-standard xrender_format having
the same depth as another xrender_format with
cairo_xlib_surface_create_with_xrender_format.

Both cairo_xlib_surface_create_with_xrender_format and
_cairo_xlib_surface_create_similar_with_format create surfaces with no visual.

The same issue exists in the xcb backend.
Comment 1 Chris Wilson 2008-09-28 10:01:26 UTC
Thanks for the patch, Karl, pushed as commit d52b55cb1b2a4e9b5fd8dd12592a227f8f6a93fc.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.