Bug 16860 - Demos do not compile in 32-bit mode
Summary: Demos do not compile in 32-bit mode
Status: RESOLVED FIXED
Alias: None
Product: Mesa
Classification: Unclassified
Component: Demos (show other bugs)
Version: git
Hardware: Other All
: medium normal
Assignee: mesa-dev
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-07-26 03:26 UTC by Guillaume Melquiond
Modified: 2009-08-24 12:30 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
Fix link issues in 32bit mode (2.85 KB, patch)
2008-07-26 03:26 UTC, Guillaume Melquiond
Details | Splinter Review

Description Guillaume Melquiond 2008-07-26 03:26:30 UTC
Created attachment 17907 [details] [review]
Fix link issues in 32bit mode

Several demos are using hand-written rules in Makefiles instead of the generic ones. In particular, they call gcc without passing flags, which leads to link failures when compiling 32-bit demos on 64-bit hosts: "incompatible ELF format" and the like.

The attached patch fixes the issue by ensuring that $(CFLAGS) is passed whenever $(CC) is called in these hand-written rules.

(It would probably make a lot more sense to not call $(CC) when linking; but I guess there is a good reason for it, so I have not changed it.)
Comment 1 Dan Nicholson 2008-07-30 08:01:42 UTC
Looks right to me. I pushed this with a couple other fixes I found outside of xdemos and demos. See 3e8e292db0794a4d2dda1605f86e8f71dbf1d661.
Comment 2 Adam Jackson 2009-08-24 12:30:45 UTC
Mass version move, cvs -> git


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.