Bug 16886 - impossible to leave MUCs with a reason
Summary: impossible to leave MUCs with a reason
Status: RESOLVED FIXED
Alias: None
Product: Telepathy
Classification: Unclassified
Component: gabble (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Telepathy bugs list
QA Contact: Telepathy bugs list
URL: http://git.collabora.co.uk/?p=user/wj...
Whiteboard:
Keywords: patch
Depends on:
Blocks: 20728
  Show dependency treegraph
 
Reported: 2008-07-29 03:56 UTC by Robert McQueen
Modified: 2009-06-10 04:17 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
patch to test leaving MUC with reason string (1021 bytes, patch)
2008-07-29 03:56 UTC, Robert McQueen
Details | Splinter Review

Description Robert McQueen 2008-07-29 03:56:28 UTC
Created attachment 17957 [details] [review]
patch to test leaving MUC with reason string

The spec (and MUC implementation in Gabble) implies that you can leave a MUC room with a message by using RemoveMembers([self_handle], "you guys suck"). I patched this into the test suite whilst fixing some other things, and discovered this in fact doesn't work. tp-glib doesn't allow removing even the self handle from the MUC, because the _CAN_REMOVE flag isn't set.

The spec probably needs a tweak to clarify you may always remove yourself from a group (even without _CAN_REMOVE), and tp-glib needs to allow that in the group mixin, and then this test (attached) can be merged in order to see whether the code in Gabble's MUC actually works.
Comment 1 Will Thompson 2009-06-02 08:22:10 UTC
My branch 'leave-muc-with-removemembers' makes removing yourself work.
Comment 2 Guillaume Desmottes 2009-06-10 03:28:23 UTC
Branch looks good to me.
Comment 3 Will Thompson 2009-06-10 04:17:31 UTC
Merged; will be in 0.7.29.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.