Bug 17309 - TpChannel should not implement TpChannelIface
Summary: TpChannel should not implement TpChannelIface
Status: RESOLVED WONTFIX
Alias: None
Product: Telepathy
Classification: Unclassified
Component: tp-glib (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Telepathy bugs list
QA Contact: Telepathy bugs list
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-08-26 04:15 UTC by Xavier Claessens
Modified: 2008-09-02 05:46 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments

Description Xavier Claessens 2008-08-26 04:15:12 UTC 
The doc of TpChannelIface says it's mainly used by TpChannelFactory which is a service-side API. TpChannelIface defines the "object-path" property which is not overriden by TpChannel but redefined in TpProxy, I think there is a problem here.

I see no reason for TpChannel to implement this interface, it could simply have its own "channel-type", "handle-type" and "handle" properties. It has already its own accessors for them.

I find this interface very confusing because of bug # and accessors are defined on TpChannel (tp_channel_get_handle) instead of TpChannelIface (tp_channel_iface_get_handle).

Is it an API/ABI break to not implement the interface and add its own properties?
Comment 1 Xavier Claessens 2008-08-26 04:16:24 UTC 
(In reply to comment #0)
> I find this interface very confusing because of bug # and accessors are defined

It is bug #17308
Comment 2 Simon McVittie 2008-09-02 05:46:02 UTC 
With hindsight, making TpChannel implement TpChannelIface was fairly pointless, but we can't drop it now (it would be an ABI break). When I fix Bug #16995 the documentation deficiency will go away, though.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.