Bug 17354 - Emits Send immediately, even if the message is queued
Summary: Emits Send immediately, even if the message is queued
Status: RESOLVED FIXED
Alias: None
Product: Telepathy
Classification: Unclassified
Component: idle (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Telepathy bugs list
QA Contact: Telepathy bugs list
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-08-29 11:32 UTC by Will Thompson
Modified: 2009-08-29 08:03 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments

Description Will Thompson 2008-08-29 11:32:03 UTC
When you send a message with Idle, as long as the recipient and message type are valid Sent will be emitted immediately.  However, the message might not actually be sent by the time Sent is emitted; if it has been split into multiple parts for length reasons, it will never have all been sent by the time Sent is emitted.

The signal emission should be delayed until the message is fully sent.
Comment 1 Will Thompson 2009-02-18 14:56:50 UTC
As per discussion on #tp: I was wrong that Sent should be delayed. (This is consistent with Gabble's new behaviour in group chats: it emits Sent just to signal that you called Send().) However, it should be emitted once per split part, not once for the whole message.
Comment 2 Jonathon Jongsma 2009-02-18 22:02:09 UTC
I have a potential fix for this in my 'sent-signal' branch: http://git.collabora.co.uk/?p=user/jonathon/telepathy-idle;a=shortlog;h=refs/heads/sent-signal
Comment 3 Will Thompson 2009-03-27 16:53:51 UTC
+1 from me.
Comment 4 Will Thompson 2009-04-01 02:37:37 UTC
Actually, I take that back:

got event:
- type dbus-signal
- args: [1238578566L,
 0L,
 u'PRIVMSG #idletest :one two three four five six seven eight nine ten eleven twelve thirteen fourteen fifteen sixteen seventeen eighteen nineteen twenty twenty-one twenty-two twenty-three twenty-four twenty-five twenty-six twenty-seven twenty-eight twenty-nine thirty thirty-one thirty-two thirty-three thirty-four thirty-five thirty-six thirty-seven thirty-eight thirty-nine forty forty-one forty-two forty-thr']
- interface: 'org.freedesktop.Telepathy.Channel.Type.Text'
- path: '/Connection/idle/irc/test_40localhost0x24e9070/MucChannel1'
- signal: 'Sent'
handled

It's emitting the 'PRIVMSG #idletest :' stuff in the Sent signal!
Comment 5 Will Thompson 2009-08-29 08:03:39 UTC
This was fixed in 0.1.4.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.