Bug 17386 - rhdMonitorValid is too strict for modes reported by PANEL
Summary: rhdMonitorValid is too strict for modes reported by PANEL
Status: RESOLVED FIXED
Alias: None
Product: xorg
Classification: Unclassified
Component: Driver/radeonhd (show other bugs)
Version: unspecified
Hardware: Other All
: medium major
Assignee: Luc Verhaegen
QA Contact: Xorg Project Team
URL: http://lists.opensuse.org/radeonhd/20...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-09-01 04:24 UTC by Rafał Miłecki
Modified: 2008-09-04 03:48 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments

Description Rafał Miłecki 2008-09-01 04:24:43 UTC 
radeonhd finds native mode for PANELs in Sony Vaio FW11*:

(II) RADEONHD(0): Query for AtomBIOS Get Panel EDID: failed
(II) RADEONHD(0): Found native mode: Modeline "1600x900"   88.54  1600 1614 1626 1630  900 902 904 906

As 1630 is not bigger than 1600+5% (check inside rhd_modes.c) this mode is rejected (horizontal blanking too narrow). The result is that radeonhd doesn't have any usable mode and X doesn't start.

Removing this strict check makes radeonhd work fine with right this modeline.

The idea is to make check in rhdMonitorValid less check for modes reported by panels.

There was short discussion about solution on IRC (Zajec, egbert, libv):
http://radeonhd.org/?page=archive_display&c=radeonhd&m=9&y=2008&d=2008-9-01
Comment 1 Egbert Eich 2008-09-04 03:11:42 UTC 
Should be fixed in:
f1c6cc865d8d0703478c3eedea2e706e911f9965
Please test.
Comment 2 Rafał Miłecki 2008-09-04 03:48:38 UTC 
Thank you Egbert! Works great.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.