Bug 17450 - configure checks for freetype backend fail if FcFini not available
Summary: configure checks for freetype backend fail if FcFini not available
Status: RESOLVED FIXED
Alias: None
Product: cairo
Classification: Unclassified
Component: freetype font backend (show other bugs)
Version: 1.6.4
Hardware: All All
: medium blocker
Assignee: David Turner
QA Contact: cairo-bugs mailing list
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-09-05 05:15 UTC by Benny Siegert
Modified: 2008-09-28 12:21 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
proposed patch (796 bytes, patch)
2008-09-05 05:15 UTC, Benny Siegert
Details | Splinter Review

Description Benny Siegert 2008-09-05 05:15:43 UTC
Created attachment 18694 [details] [review]
proposed patch

I am trying to compile cairo 1.6.4 on MirOS BSD (an OpenBSD variant). The fontconfig included in the base system does not have the FcFini() function. As I gathered from searching the mailing list archives, this function is optional. However, on systems without FcFini(), the freetype backend is completely disabled.

From reading the source code, I do not think that FcFini is really essential, and any calls to it are protected by #ifdef HAVE_FCFINI anyway. Thus, I made a small patch for the configure script to make a missing FcFini non-fatal for the freetype font backend.

What's ironic is that this bug had already existed as bug 3951. It was fixed in 0.9.3.
Comment 1 Carl Worth 2008-09-05 10:03:02 UTC
Thanks for the reminder. We've already fixed this on the "master" branch of cairo, but I'll leave this bug open as a "blocker" until we make sure that this fix gets on the 1.6 branch in preparation for a 1.6.6 release.

-Carl
Comment 2 Chris Wilson 2008-09-28 12:21:08 UTC
When 1.8 has superseded 1.6 as the stable branch, so we can now close this bug.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.