Bug 17822 - please add some news compose combinations to en_US.UTF8 Compose file
Summary: please add some news compose combinations to en_US.UTF8 Compose file
Status: RESOLVED FIXED
Alias: None
Product: xorg
Classification: Unclassified
Component: Lib/Xlib (data) (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Xorg Project Team
QA Contact: Xorg Project Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-09-29 00:08 UTC by Frédéric Boiteux
Modified: 2008-12-17 03:44 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments
new dead keys combinations for french-dvorak "bépo" keyboard layout. (16.73 KB, patch)
2008-09-29 00:08 UTC, Frédéric Boiteux
no flags Details | Splinter Review
update of the previous patch (16.04 KB, patch)
2008-11-11 12:37 UTC, Frédéric Boiteux
no flags Details | Splinter Review

Description Frédéric Boiteux 2008-09-29 00:08:28 UTC
Created attachment 19277 [details] [review]
new dead keys combinations for french-dvorak "bépo" keyboard layout.

Hello,

  I'm in a community defining a new french dvorak keyboard layout (see http://clavier-dvorak.org/wiki/), and for our needs, we have defined some new combinations using exising and new dead keys : indeed we used some unaffected UTF-8 codes to define some new dead keys, like a dead stroke key (dead stroke + 'equal' key = 'different' sign for example), a monetary dead key (dead monetary + S = dollar), a greek dead key (dead greek + L = lambda) and an "comma under" dead key.
  In Xorg architecture, we are using the Compose.pre file of en_US.UTF8 locale (in libX11).
  As we have reached a stable release version (1.0rc2), we would like to include it in Xorg (a previous two years old one had already been included, without composition keys). I've put in attachment a patch describing our composition addition to the existing file, could you include it in the mainstream Xorg ?
FYI, the layout update is in bug #17821.

  with regards
Comment 1 James Cloos 2008-09-30 13:07:52 UTC
I have some concerns about using the U+FDDx characters as dead keys.

We prefer actual dead_key symbols.

There already is a dead_stroke, so:  s/UFDD0/dead_stroke/g.

In the pre-utf8 locales dead_cedilla did double duty as a dead_comma for
those locales which have U+0218 thru U+012B (ȘșȚț) instead of U+015E,
U+015F, U+0162 and U+0163 (ŞşŢţ).  I’ll ask for some consensus about
adding dead_comma and even dead_currency.

Adding a dead_greek seems unlikely, however.  With xkb you can have the
greek layout available by using multiple layouts and the grp toggling
options.  A dead key for greek should not be needed.

I will add the compose sequences which do not use UFDDx symbols,
including the dead_stroke ones.  And the dead_comma/dead_currency
if there is consensus to add those symbold to keysymdef.
Comment 2 Frédéric Boiteux 2008-10-01 00:02:45 UTC
About the UFDDx dead keys, I mentioned it as I thought it could be a problem. When we use these numbers to define new dead keys, we didn't know about dead_stroke existence. I found a file with keysyms.txt, but it is obviously out of date : could you tell me where to find the latest one, I'm lost in the whole X.org software ?
So the UFFD0 should be replaced by 'dead_stroke', it's cleaner.

About the 'dead_comma' (UFDD3), it don't give the same characters as the dead_cedilla (which is also present in the Bépo layout), so the former can't be 
replaced by the latter.

It could be really nice if new dead_* symbols could be defined in place of these UFDD* hacks, and I prefer to wait for them and then submit new patches with Bépo layout and Compositions updated (as I missed the xkeyboard-config release deadline, it could wait for some days...).

And for the dead_greek code, yes, you could achieve the same result with groups, but :
- our keyboard layout has been defined with OS independance in mind (ever if I used only Unix-like OS, other people has a driver for Windows or Mac OS systems), and I'm not sure the group mechamisn could be realized in those other OS.
- it is more consistent with the behaviour of the layout, which defines some dead keys to be able to add some foreign [for french] characters with a simple composition.
If such a dead_greek keysym isn't added, could we include the Bépo Layout in Xorg with its existing UFDD2 code ?

  Fred.
Comment 3 Frédéric Boiteux 2008-10-01 06:32:55 UTC
About dead stoke, as the keysym already exists, I should examine current Compositions for existing ones with this keysym, to be sure to remove any redondancies or conflicts in the patch of bug 17822.
Comment 4 Frédéric Boiteux 2008-10-03 05:31:49 UTC
I've reviewed my libX11's patch about UFDD0 replaced to dead_stroke : I've found 21 redundancies between standard libX11 compositions and ones I'd like to add, so I should remove these 21 lines in my patch. I'd also like to replace UTF-8 codes (UXXXX) by definitions from latest keysymdef.h I've downloaded.

So, before to submit an updated patch, I'd like to know if a dead_currency, dead_greek and dead_commabelow (more than dead_comma) will be created : I'll update both my xkeyboard-config and libX11 patches accordingly.

If you have better names for these dead_keys, please use them.

If the dead_greek can't be added, I'd like to keep the UFDDx code instead.
Comment 5 James Cloos 2008-10-15 09:59:35 UTC
Below comma keysym added to x11proto in commit d7147e09faaf1eded3a68c15ff3f76f8f60a272d.
Comment 6 Frédéric Boiteux 2008-11-11 12:37:33 UTC
Created attachment 20224 [details] [review]
update of the previous patch

This is an update of the previous patch, taking account of dead_stroke and dead_belowcomma defined in x11proto.
Comment 7 Frédéric Boiteux 2008-12-17 03:44:31 UTC
As the dead_greek key hasn't been accepted (and thus not put in Xorg's Bépo layout) and that all other key combinations have been added, this bug can be closed.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.