Bug 18091 - [fixed in git] include IMPLEMENT(foo) boilerplate in interface documentation
Summary: [fixed in git] include IMPLEMENT(foo) boilerplate in interface documentation
Status: RESOLVED FIXED
Alias: None
Product: Telepathy
Classification: Unclassified
Component: tp-glib (show other bugs)
Version: unspecified
Hardware: Other All
: low enhancement
Assignee: Telepathy bugs list
QA Contact: Telepathy bugs list
URL: http://git.collabora.co.uk/?p=user/sm...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-10-16 06:05 UTC by Will Thompson
Modified: 2009-08-17 04:59 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments

Description Will Thompson 2008-10-16 06:05:43 UTC
Just about every implementation of every D-Bus interface in every CM uses this idiom:

#define IMPLEMENT(x) tp_svc_channel_implement_##x (\
    klass, gabble_im_channel_##x)
  IMPLEMENT(close);
  IMPLEMENT(get_channel_type);
  IMPLEMENT(get_handle);
  IMPLEMENT(get_interfaces);
#undef IMPLEMENT

I always end up cargo-culting this, and it's easy to get wrong, particularly if I accidentally copy from somewhere that reimplements most but not all of the methods.

It'd be nice to have this boilerplate in the documentation of the interface type, as a canonical source.
Comment 2 Simon McVittie 2009-07-24 04:19:21 UTC
Removing patch tag so this bug leaves the review queue.
Comment 3 Simon McVittie 2009-08-17 04:59:05 UTC
Fixed in 0.7.34
Comment 4 Simon McVittie 2009-08-17 04:59:12 UTC
Fixed in 0.7.34


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.