Bug 18166 - don't fill hash tables with dead entries as fast as possible
Summary: don't fill hash tables with dead entries as fast as possible
Status: RESOLVED WONTFIX
Alias: None
Product: cairo
Classification: Unclassified
Component: general (show other bugs)
Version: 1.6.5
Hardware: Other All
: medium normal
Assignee: Keith Packard
QA Contact: cairo-bugs mailing list
URL: https://bugzilla.mozilla.org/show_bug...
Whiteboard:
Keywords:
Depends on: 18165
Blocks: 17399
  Show dependency tree / graph
 
Reported: 2008-10-21 22:40 UTC by Karl Tomlinson
Modified: 2008-11-07 12:45 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments
patch (591 bytes, patch)
2008-10-21 22:40 UTC, Karl Tomlinson 		Details | Splinter Review
View All

Description Karl Tomlinson 2008-10-21 22:40:29 UTC 
Created attachment 19801 [details] [review]
patch

modify _cairo_hash_table_lookup_internal to return the first available
(dead or free) entry rather than the first never-used entry, when there is no match.

This patch actually won't have any effect if bug 18165 is fixed as first_available won't be set when key_is_unique, and callers that have key_is_unique == FALSE only care about live entries.

However, this patch could be considered as an alternative to fixing bug 18165, or just to make the code look sensible.
Comment 1 Chris Wilson 2008-11-07 12:45:55 UTC 
I prefer the patch from bug 18165.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.