Created attachment 19848 [details] [review] patch to avoid some gcc warnings, reporting correct resource ranges Attached is a patch for xorg-server-1.5.2 to avoid various compiler warnings about format vs. argument type mismatches. On our i686 (LE32) systems, one of them causes the server to report (Xorg.0.log) PCI:*(0@1:0:0) Matrox Graphics, Inc. MGA G550 AGP rev 1, Mem @ 0xf8000000/0, 0xfbf00000/0, 0xfb000000/0, BIOS @ 0x????????/131072 instead of PCI:*(0@1:0:0) Matrox Graphics, Inc. MGA G550 AGP rev 1, Mem @ 0xf8000000/33554432, 0xfbf00000/16384, 0xfb000000/8388608, BIOS @ 0x????????/131072
Thanks for the patch. I applied most of the changes to git master in commit 16b11cd03d8c5def07f0e598f237f71a37883a46 Only did not apply the warnings about format int but argument type is CARD32, as those should be printed only when debugging the code. The warning comes of ''typedef unsigned long CARD32'', that is conditional, and only on 64 bits architectures it will be correctly defined as ''typedef unsigned int CARD32''.
(In reply to comment #1) > Thanks for the patch. I applied most > of the changes to git master in commit > 16b11cd03d8c5def07f0e598f237f71a37883a46 > > Only did not apply the warnings about > format int but argument type is CARD32, > as those should be printed only when > debugging the code. The warning comes > of ''typedef unsigned long CARD32'', that > is conditional, and only on 64 bits > architectures it will be correctly defined > as ''typedef unsigned int CARD32''. > Isn't it about time to change that as well on 32 bits, thereby getting rid of zillions of warnings (in case warnings are enabled)? I don't think any Xorg program still compiles on systems where int is 16 bits.
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.