Bug 18331 - Build failure of xlib backend for Mac OS X 110.4.11
Summary: Build failure of xlib backend for Mac OS X 110.4.11
Status: RESOLVED DUPLICATE of bug 18385
Alias: None
Product: cairo
Classification: Unclassified
Component: xlib backend (show other bugs)
Version: 1.8.2
Hardware: All Mac OS X (All)
: medium blocker
Assignee: Carl Worth
QA Contact: cairo-bugs mailing list
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-10-31 16:15 UTC by Marius Schamschula
Modified: 2008-11-05 08:53 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
add missing RenderNone RenderNormal constants (204 bytes, patch)
2008-11-03 16:38 UTC, Jarod Eells
Details | Splinter Review

Description Marius Schamschula 2008-10-31 16:15:29 UTC
While I had no issue building cairo 1.8.2 under Mac OS X 10.5.5, the build under 10.4.11 fails (PPC/Intel):

../doltcompile gcc -DHAVE_CONFIG_H -I. -I..  -I. -I/usr/local/include/pixman-1      -I/usr/local/include/freetype2 -I/usr/local/include   -I/usr/local/include   -I/usr/local/include/libpng12     -DXTHREADS -I/usr/local/include -I/usr/X11R6/include      -Wall -Wextra -Wsign-compare -Werror-implicit-function-declaration -Wpointer-arith -Wwrite-strings -Wstrict-prototypes -Wmissing-prototypes -Wmissing-declarations -Wnested-externs -Wpacked -Wswitch-enum -Wstrict-aliasing=2 -Winit-self -Wdeclaration-after-statement -Wold-style-definition -Wno-missing-field-initializers -Wno-unused-parameter -Wno-long-long -Winline -fno-strict-aliasing -fno-common -Wp,-D_FORTIFY_SOURCE=2            -I/usr/X11R6/include  -I/usr/local/include  -g -O2 -MT cairo-xlib-surface.lo -MD -MP -MF .deps/cairo-xlib-surface.Tpo -c -o cairo-xlib-surface.lo cairo-xlib-surface.c
cairo-xlib-surface.c: In function '_cairo_xlib_surface_set_attributes':
cairo-xlib-surface.c:1440: error: 'RepeatNone' undeclared (first use in this function)
cairo-xlib-surface.c:1440: error: (Each undeclared identifier is reported only once
cairo-xlib-surface.c:1440: error: for each function it appears in.)
cairo-xlib-surface.c:1443: error: 'RepeatNormal' undeclared (first use in this function)
make[3]: *** [cairo-xlib-surface.lo] Error 1
make[2]: *** [all] Error 2
make[1]: *** [all-recursive] Error 1
make: *** [all] Error 2

Since the Quartz backend still isn't prime time, this is a show stopper.
Comment 1 Carl Worth 2008-10-31 16:45:35 UTC
Marius,

Thanks for the report.

Ryan Schmidt recently pointed out the same problem on the mailing list and we diagnosed the problem there.

The problem comes from attempting to build cairo-xlib against a system with an obsolete version of the renderproto package, (which fails to define the RepeatNone and RepeatNormal macros).

To get things working for now, you can just replace RepeatNone with 0 and RepeatNormal with 1.

I'll leave this bug report open until we apply a suitable fix to the 1.8 branch. And I'll mark this as a blocker so that we remember to fix it for a 1.8.4 release real soon now.

Thanks again,

-Carl
Comment 2 Marius Schamschula 2008-10-31 17:32:42 UTC
Carl,

Thanks

I patched the two values as you suggested. Now the build succeeds.
Comment 3 Jarod Eells 2008-11-03 16:38:50 UTC
Created attachment 20026 [details] [review]
add missing RenderNone RenderNormal constants
Comment 4 Behdad Esfahbod 2008-11-05 08:53:22 UTC
Thanks.  This is fixed in master now.  Will be in 1.8.4

*** This bug has been marked as a duplicate of bug 18385 ***


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.